Skip to content

PEP 623: Remove wstr from Unicode #92536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
methane opened this issue May 9, 2022 · 4 comments
Closed

PEP 623: Remove wstr from Unicode #92536

methane opened this issue May 9, 2022 · 4 comments
Labels
type-feature A feature request or enhancement

Comments

@methane
Copy link
Member

methane commented May 9, 2022 •
edited by bedevere-bot
Loading

Feature or enhancement

PEP 623

Linked PRs
@methane methane added the type-feature A feature request or enhancement label May 9, 2022
@methane methane mentioned this issue May 9, 2022
Merged
@vstinner
Copy link
Member

FYI the lxml project still uses uses deprecated functions:

src/lxml/parser.pxi:            py_buffer_len = python.PyUnicode_GET_DATA_SIZE(utext)
src/lxml/parser.pxi:            c_len = python.PyUnicode_GET_DATA_SIZE(text)
src/lxml/python.pxd:    cdef Py_ssize_t PyUnicode_GET_DATA_SIZE(object ustring)

Compiler warnings on Python 3.11:

src/lxml/etree.c: In function ‘__pyx_f_4lxml_5etree_11_BaseParser__parseUnicodeDoc’:
src/lxml/etree.c:119132:5: warning: ‘PyUnicode_GET_DATA_SIZE’ is deprecated [-Wdeprecated-declarations]
119132 |     __pyx_v_py_buffer_len = PyUnicode_GET_DATA_SIZE(__pyx_v_utext);
       |     ^~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/python3.11/unicodeobject.h:1042,
                 from /usr/include/python3.11/Python.h:51,
                 from src/lxml/etree.c:99:
/usr/include/python3.11/cpython/unicodeobject.h:657:26: note: declared here
  657 | static inline Py_ssize_t PyUnicode_GET_DATA_SIZE(PyObject *op)
      |                          ^~~~~~~~~~~~~~~~~~~~~~~
src/lxml/etree.c:119141:5: warning: ‘PyUnicode_AS_DATA’ is deprecated [-Wdeprecated-declarations]
119141 |     __pyx_v_c_text = PyUnicode_AS_DATA(__pyx_v_utext);
       |     ^~~~~~~~~~~~~~
/usr/include/python3.11/cpython/unicodeobject.h:691:27: note: declared here
  691 | static inline const char* PyUnicode_AS_DATA(PyObject *op)
      |                           ^~~~~~~~~~~~~~~~~
src/lxml/etree.c: In function ‘__pyx_f_4lxml_5etree__parseDoc’:
src/lxml/etree.c:125721:7: warning: ‘PyUnicode_GET_DATA_SIZE’ is deprecated [-Wdeprecated-declarations]
125721 |       __pyx_v_c_len = PyUnicode_GET_DATA_SIZE(__pyx_v_text);
       |       ^~~~~~~~~~~~~
/usr/include/python3.11/cpython/unicodeobject.h:657:26: note: declared here
  657 | static inline Py_ssize_t PyUnicode_GET_DATA_SIZE(PyObject *op)
      |                          ^~~~~~~~~~~~~~~~~~~~~~~

methane added a commit that referenced this issue May 12, 2022
@methane
gh-92536: PEP 623: Remove wstr and legacy APIs from Unicode (GH-92537)
f9c9354
@methane
Copy link
Member Author

methane commented May 12, 2022

Thank you for reporting.
I reported it to lxml. https://bugs.launchpad.net/lxml/+bug/1973155

I tried to fix it but I don't have enough skill to write compile-time switch in Cython.
If it is difficult to fix it soon, I will resurrect PyUnicode_AS_DATA and PyUnicode_GET_DATA_SIZE as dummy function that just raise an exception.

@vstinner
Copy link
Member

I tried to fix it but I don't have enough skill to write compile-time switch in Cython.

I wrote https://github.com/gevent/gevent/pull/1872/files which has conditional code depending on the Python version.

methane added a commit to methane/cpython that referenced this issue May 13, 2022
@methane
pythongh-92536: Doc update about Py_UNICODE removal
54e54b1
methane added a commit that referenced this issue May 13, 2022
@methane
gh-92536: Doc update about Py_UNICODE removal (GH-92756)
e371d5d
sweeneyde added a commit that referenced this issue May 17, 2022
@sweeneyde
gh-92536: Update unicode struct size to ensure MemoryError is raised (G…
19a4252 
…H-92867)
@methane methane closed this as completed May 19, 2022
@vstinner
Copy link
Member

Well done! That was a long journey ;-)

vstinner pushed a commit that referenced this issue May 23, 2022
@wjakob
gh-92536: Mark PyUnicode_READY() argument as unused (#93011)
b2694ab
vstinner added a commit to vstinner/cpython that referenced this issue Jun 1, 2023
@vstinner
pythongh-92536: Argument Clinic no longer emits PyUnicode_READY()
def4fab 
Since Python 3.12, PyUnicode_READY() does nothing and always
returns 0.
vstinner added a commit to vstinner/cpython that referenced this issue Jun 1, 2023
@vstinner
pythongh-92536: Argument Clinic no longer emits PyUnicode_READY()
e19ae66 
Since Python 3.12, PyUnicode_READY() does nothing and always
returns 0.
@bedevere-bot bedevere-bot mentioned this issue Jun 1, 2023
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Jun 1, 2023
@vstinner
pythongh-92536: Argument Clinic no longer emits PyUnicode_READY()
4960003 
Since Python 3.12, PyUnicode_READY() does nothing and always
returns 0.
vstinner added a commit to vstinner/cpython that referenced this issue Jun 1, 2023
@vstinner
pythongh-92536: Remove PyUnicode_READY() calls
7861cef 
Since Python 3.12, PyUnicode_READY() does nothing and always
returns 0.
vstinner added a commit to vstinner/cpython that referenced this issue Jun 1, 2023
@vstinner
pythongh-92536: Remove PyUnicode_READY() calls
63ba3dc 
Since Python 3.12, PyUnicode_READY() does nothing and always
returns 0.
@bedevere-bot bedevere-bot mentioned this issue Jun 1, 2023
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Jun 1, 2023
@vstinner
pythongh-92536: Argument Clinic no longer emits PyUnicode_READY()
c591ad7 
Since Python 3.12, PyUnicode_READY() does nothing and always
returns 0.
vstinner added a commit that referenced this issue Jun 1, 2023
@vstinner
gh-92536: Argument Clinic no longer emits PyUnicode_READY() (#105208)
cbb9ba8 
Since Python 3.12, PyUnicode_READY() does nothing and always
returns 0.

Argument Clinic now also checks for .cpp files (PC/_wmimodule.cpp).
vstinner added a commit that referenced this issue Jun 1, 2023
@vstinner
gh-92536: Remove PyUnicode_READY() calls (#105210)
ef30093 
Since Python 3.12, PyUnicode_READY() does nothing and always
returns 0.
@vstinner vstinner mentioned this issue Sep 7, 2023
Closed
erlend-aasland pushed a commit to erlend-aasland/devguide that referenced this issue Sep 8, 2023
@methane @erlend-aasland
python/cpython#92536: PEP 623: Remove wstr and legacy APIs from Unico…
e1df607 
…de (python/cpython#92537)
AA-Turner pushed a commit to AA-Turner/devguide that referenced this issue Sep 13, 2023
@methane
python/cpython#92536: PEP 623: Remove wstr and legacy APIs from Unico…
03d39ac 
…de (python/cpython#92537)
erlend-aasland pushed a commit to python/devguide that referenced this issue Sep 26, 2023
@methane @erlend-aasland
python/cpython#92536: PEP 623: Remove wstr and legacy APIs from Unico…
09f1afa 
…de (python/cpython#92537)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vstinner @methane