tarfile list() method does not show file type

[val-shkolnikov]

BPO	43098
Nosy	@ethanfurman, @akulakov, @val-shkolnikov
Files	patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/ethanfurman'
closed_at = None
created_at = <Date 2021-02-02.04:35:47.148>
labels = ['3.8', 'type-bug', '3.7']
title = 'tarfile list() method does not show file type'
updated_at = <Date 2021-12-07.21:18:14.344>
user = 'https://github.com/val-shkolnikov'

bugs.python.org fields:

activity = <Date 2021-12-07.21:18:14.344>
actor = 'val.shkolnikov'
assignee = 'ethan.furman'
closed = False
closed_date = None
closer = None
components = []
creation = <Date 2021-02-02.04:35:47.148>
creator = 'val.shkolnikov'
dependencies = []
files = ['49786']
hgrepos = []
issue_num = 43098
keywords = []
message_count = 4.0
messages = ['386129', '397039', '407643', '407971']
nosy_count = 3.0
nosy_names = ['ethan.furman', 'andrei.avk', 'val.shkolnikov']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue43098'
versions = ['Python 3.7', 'Python 3.8']

Linked PRs

• gh-87264: tarfile list() method does not show file type. #29974
• gh-87264:tarfile list() method does not show file type. #100127
• gh-87264: Convert tarinfo type to stat type #113230

[val-shkolnikov]

The list() method of TarFile tarfile object shows question mark in place of file type in verbose mode. For instance
python3 -m tarfile -v -l my.tar
?rwxr-xr-x vals/users 0 2021-01-16 18:28:30 bin/
?rwxr-x--- vals/users 266 2021-01-16 18:28:30 bin/backmine.sh
?rwxr-xr-x vals/users 950 2018-01-02 10:39:18 bin/tm.sh
?rwxrwxrwx vals/users 0 2021-01-16 11:49:36 bin/source-highlight -> ../source-highlight/bin/source-highlight
?rwxr-xr-x vals/users 435 2011-03-27 15:38:06 bin/dd.sh

This is because the call stat.filemode(tarinfo.mode) does not pass tarinfo.type to stat.filemode. The type needs to be properly encoded and added to the argument.

My patch is attached. Verified under Linux, Cygwin and Windows.

[akulakov]

I've tested this patch on OS X with symbolic links, dirs, files and it works fine.

[akulakov]

Val: contributions are only now accepted in form of github PRs, not patches.

[val-shkolnikov]

contributions are only now accepted in form of github PRs
Done