Repository navigation
Improve colorsys.rgb_to_hls code #86618
Description
| BPO | 42452 |
|---|---|
| Nosy | @terryjreedy, @jjerphan |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2020-11-28.07:12:39.305>
created_at = <Date 2020-11-24.14:09:55.925>
labels = ['type-feature', 'library', '3.10']
title = 'Improve colorsys.rgb_to_hls code'
updated_at = <Date 2020-11-28.07:12:39.304>
user = 'https://github.com/jjerphan'bugs.python.org fields:
activity = <Date 2020-11-28.07:12:39.304>
actor = 'terry.reedy'
assignee = 'none'
closed = True
closed_date = <Date 2020-11-28.07:12:39.305>
closer = 'terry.reedy'
components = ['Library (Lib)']
creation = <Date 2020-11-24.14:09:55.925>
creator = 'jjerphan'
dependencies = []
files = []
hgrepos = []
issue_num = 42452
keywords = []
message_count = 3.0
messages = ['381748', '381981', '381982']
nosy_count = 2.0
nosy_names = ['terry.reedy', 'jjerphan']
pr_nums = ['23306']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue42452'
versions = ['Python 3.10']
Activity
jjerphan commentedon Nov 24, 2020
This issue has been created after the PR.
terryjreedy commentedon Nov 28, 2020
New changeset f919531 by Julien Jerphanion in branch 'master':
bpo-42452: Improve colorsys.rgb_to_hls code (GH-23306)
f919531
terryjreedy commentedon Nov 28, 2020
The change was a suggested TODO in the code itself.
[-]FIX Optimize 'rgb_to_hls'[/-][+]Improve colorsys.rgb_to_hls code[/+][-]FIX Optimize 'rgb_to_hls'[/-][+]Improve colorsys.rgb_to_hls code[/+]terryjreedy commentedon Jul 11, 2023
As noted in issue #106498, the TODO comment and this patch were incorrect in that
2.0 - maxc - mincdoes not equal2.0 - (maxc + minc)formaxc, minc = 1.0, 0.9999999999999999because the float sum is 2.0, leaving 0.0 and causing ZeroDivisionError, whereas the correct subtraction leaves1.1102230246251565e-16.pythongh-106498: Revert incorrect colorsys.rgb_to_hls change
gh-106498: Revert incorrect colorsys.rgb_to_hls change (#106627)
pythongh-106498: Revert incorrect colorsys.rgb_to_hls change (pythonG…
pythongh-106498: Revert incorrect colorsys.rgb_to_hls change (pythonG…
[3.12] gh-106498: Revert incorrect colorsys.rgb_to_hls change (GH-106627
[3.11] gh-106498: Revert incorrect colorsys.rgb_to_hls change (GH-106627