Repository navigation
More correct string truncating in PyUnicode_FromFormat() #70278
Description
| BPO | 26090 |
|---|---|
| Nosy | @gvanrossum, @vstinner, @ezio-melotti, @serhiy-storchaka |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = None
created_at = <Date 2016-01-12.09:54:14.845>
labels = ['interpreter-core', 'type-feature']
title = 'More correct string truncating in PyUnicode_FromFormat()'
updated_at = <Date 2016-06-21.07:22:59.885>
user = 'https://github.com/serhiy-storchaka'bugs.python.org fields:
activity = <Date 2016-06-21.07:22:59.885>
actor = 'Drekin'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Interpreter Core']
creation = <Date 2016-01-12.09:54:14.845>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 26090
keywords = []
message_count = 5.0
messages = ['258092', '258095', '258108', '258111', '258118']
nosy_count = 5.0
nosy_names = ['gvanrossum', 'vstinner', 'ezio.melotti', 'serhiy.storchaka', 'Drekin']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'needs patch'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue26090'
versions = ['Python 3.6']
Activity
serhiy-storchaka commentedon Jan 12, 2016
The C code often uses %.<number><format> in PyUnicode_FromFormat(). %.200s protects from unlimited output when broken pointer points on random non-null-terminated data. %.200R is used to limit the size of human-readable messages.
In all these case formatted string can look well-formed with short data, but mis-formed (not closed quote, truncated backslash escaping or � decoded from truncated UTF-8 sequence) with long data.
I propose to make truncating in PyUnicode_FromFormat() more smart.
vstinner commentedon Jan 12, 2016
See my old issue bpo-10833 which proposed to *remove* the arbitrary limit
on strings. It was rejected.
gvanrossum commentedon Jan 12, 2016
Could we make this feature available at the Python level too? It sounds
really useful.
--Guido (mobile)
On Jan 12, 2016 2:01 AM, "STINNER Victor" <report@bugs.python.org> wrote:
serhiy-storchaka commentedon Jan 12, 2016
I think we can make this feature available with classic formatting '%.100r', but with new formatting '{0:.100!r}' (especially with f-strings) this can be not so easy.
gvanrossum commentedon Jan 12, 2016
Well it seems a little odd to spend effort on a corner case of the C-level
error messages if we can't even replicate it in pure Python.
pythongh-70278: Fix PyUnicode_FromFormat() with precision for %s and %V
serhiy-storchaka commentedon Jun 11, 2024
#120365 solves item 4. It is the simplest of the mentioned problems. It only exists at the C level.
vstinner commentedon Jun 12, 2024
I suggest adding
(...)to indicate that the string is truncated.gh-70278: Fix PyUnicode_FromFormat() with precision for %s and %V (GH…
pythongh-70278: Fix PyUnicode_FromFormat() with precision for %s and …
pythongh-70278: Fix PyUnicode_FromFormat() with precision for %s and …
pythongh-70278: Fix PyUnicode_FromFormat() with precision for %s and …