Skip to content

Attempt to further increase test coverage of calendar module #69714

Closed
#93655
Closed
Attempt to further increase test coverage of calendar module#69714
#93655
Labels
testsTests in the Lib/test dirtype-featureA feature request or enhancement

Description

@RohitMediratta
RohitMediratta
mannequin
opened on Nov 1, 2015
BPO 25528
Nosy @rhettinger, @vadmium, @serhiy-storchaka, @matrixise, @iritkatriel
Files
  • mywork.patch: Patch to increase coverage for 3 additional lines
  • mywork_update.patch: Updated patch showing the correct diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2015-11-01.09:57:43.791>
labels = ['type-feature', 'tests']
title = 'Attempt to further increase test coverage of calendar module'
updated_at = <Date 2022-03-22.21:27:14.499>
user = 'https://bugs.python.org/RohitMediratta'

    bugs.python.org fields:

    activity = <Date 2022-03-22.21:27:14.499>
actor = 'iritkatriel'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Tests']
creation = <Date 2015-11-01.09:57:43.791>
creator = 'Rohit Mediratta'
dependencies = []
files = ['40916', '41109']
hgrepos = []
issue_num = 25528
keywords = ['patch']
message_count = 7.0
messages = ['253836', '254421', '255047', '255416', '255417', '255423', '415815']
nosy_count = 6.0
nosy_names = ['rhettinger', 'martin.panter', 'serhiy.storchaka', 'matrixise', 'Rohit Mediratta', 'iritkatriel']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue25528'
versions = ['Python 3.6']

    Linked PRs

    Activity

    1. RohitMediratta commented on Nov 1, 2015

      @RohitMediratta
      RohitMedirattamannequin
      on Nov 1, 2015
      MannequinAuthor

      Opened to submit a patch.

      • make patchcheck succeeded
      • full testsuite succeeded
      • Old coverage
        Lib/calendar.py 375 54 86% 511, 519, 541, 608-699, 703
      • New coverage
        Lib/calendar.py 375 51 86% 608-699, 703
    2. RohitMediratta
      added
      testsTests in the Lib/test dir
      type-featureA feature request or enhancement
      on Nov 1, 2015

    3. vadmium commented on Nov 9, 2015

      @vadmium
      vadmium
      on Nov 9, 2015
      Member

      Rohit, it looks like your patch is reversed. The lines with a + sign already exist; are the - lines your proposed additions? Equivalently, revision f7db966c9fee already exists; is fb9d4ccbadf0 your new proposed revision?

      Assuming the patch is reversed, I suggest keeping the locale=None case, perhaps as a separate test case or loop iteration. Otherwise you are throwing out one test case to add another.

    4. RohitMediratta commented on Nov 21, 2015

      @RohitMediratta
      RohitMedirattamannequin
      on Nov 21, 2015
      MannequinAuthor

      Thanks for the comments. I did indeed have the patch reversed. I've resolved it here.

      Martin: I had the locale=None case in the patch.

    5. matrixise commented on Nov 26, 2015

      @matrixise
      matrixise
      on Nov 26, 2015
      Member

      no problem about the second patch of Rohit.

      pass the test with default and I have tested the code in the REPL.

    6. serhiy-storchaka commented on Nov 26, 2015

      @serhiy-storchaka
      serhiy-storchaka
      on Nov 26, 2015
      Member

      The problem with Rohit's patch is that it throws out existing test case.

    7. matrixise commented on Nov 26, 2015

      @matrixise
      matrixise
      on Nov 26, 2015
      Member

      Sure,

      But the patch is correct.

      Now, you are right, we have to ask him a new patch where the function is really tested.

    8. iritkatriel commented on Mar 22, 2022

      @iritkatriel
      iritkatriel
      on Mar 22, 2022
      Member

      The patch needs to be reviewed. If the tests are still relevant and increase coverage, it needs to be converted to a GitHub PR. Otherwise this issue can be closed.

      See also bpo-13330.

    9. ezio-melotti
      transferred this issue fromon Apr 10, 2022

    10. AA-Turner commented on Jun 3, 2022

      @AA-Turner
      AA-Turner
      on Jun 3, 2022
      Member

      This hasn't been converted into a PR, if someone would like to we can re-open this issue in the future.

      A

    11. AA-Turner
      closed this as not plannedon Jun 3, 2022
    12. bxsx
      added 3 commits that reference this issue on Jun 9, 2022

      pythongh-69714: Restore the test thrown out by cb0523e

      78935da

      pythongh-69714: Increase test coverage for `calendar.Locale{Text|HTML…

      0dd6321

      pythongh-69714: Add missing test cases for custom locale in `calendar…

      69c8f4f

    13. 6 remaining items

    14. AA-Turner
      reopened this on Jun 9, 2022

    15. AA-Turner commented on Jun 9, 2022

      @AA-Turner
      AA-Turner
      on Jun 9, 2022
      Member

      Reopening as a new PR has appeared (#93655).

      A

    16. bxsx
      added 8 commits that reference this issue on Jun 9, 2022

      pythongh-69714: Reorder locale in the test case

      d28e2e4

      pythongh-69714: Extract test case

      bbdc393

      Revert "pythongh-69714: Remove unreachable code (and increase test co…

      40e0da3

      Revert "Revert "pythongh-69714: Remove unreachable code (and increase…

      64cb029

      pythongh-69714: Move the validation to the beginning of the function

      8b7bc06

      pythongh-69714: Increase test coverage for illegal arguments

      de21a51

      Revert "pythongh-69714: Add more test cases to `calendar` cmdline"

      ab5a508

      pythongh-69714: Split tests for LocaleTextCalendar and LocaleHTMLCale…

      e73fc9e

    17. terryjreedy commented on Feb 24, 2023

      @terryjreedy
      terryjreedy
      on Feb 24, 2023
      Member

      @bxsx Please leave the issue number off the commit message for all PR branch commits after the first. It spams the issue with unneeded info that is also on the PR itself.

    18. bxsx
      added 2 commits that reference this issue on Jul 21, 2023

      Merge branch 'main' into pythongh-69714/calendar-test-coverage

      87feac0

      Merge branch 'main' into pythongh-69714/calendar-test-coverage

      81d09b2
    19. ambv
      closed this as completedin #93655on Jul 22, 2023
    20. ambv
      added a commit that references this issue on Jul 22, 2023

      gh-69714: Make `calendar` module fully tested (#93655)

      2aba047
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      testsTests in the Lib/test dirtype-featureA feature request or enhancement

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions