Repository navigation
shutil.chown should support dir_fd and follow_symlinks keyword arguments #62308
Description
| BPO | 18108 |
|---|---|
| Nosy | @cjwatson, @PCManticore, @berkerpeksag, @hynek, @phmc, @avinassh, @tahia-khan |
| PRs | |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = None
created_at = <Date 2013-05-31.13:09:57.018>
labels = ['easy', 'type-feature', 'library']
title = 'shutil.chown should support dir_fd and follow_symlinks keyword arguments'
updated_at = <Date 2019-10-28.20:48:21.699>
user = 'https://github.com/cjwatson'bugs.python.org fields:
activity = <Date 2019-10-28.20:48:21.699>
actor = 'pconnell'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2013-05-31.13:09:57.018>
creator = 'cjwatson'
dependencies = []
files = ['35633']
hgrepos = []
issue_num = 18108
keywords = ['patch', 'easy']
message_count = 7.0
messages = ['190404', '220430', '220564', '220565', '221675', '346893', '351543']
nosy_count = 7.0
nosy_names = ['cjwatson', 'Claudiu.Popa', 'berker.peksag', 'hynek', 'pconnell', 'avi', 'ta1hia']
pr_nums = ['15811']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue18108'
versions = ['Python 3.5']
Activity
cjwatson commentedon May 31, 2013
Python 3.3 added the dir_fd and follow_symlinks keyword arguments to os.chown; it also added the shutil.chown function. Unfortunately the latter, while useful, does not support these new keyword arguments. It would be helpful if it did.
PCManticore commentedon Jun 13, 2014
Hi. Would you like to provide a patch?
berkerpeksag commentedon Jun 14, 2014
Here's a patch.
PCManticore commentedon Jun 14, 2014
Looks good to me. But aren't the last two lines skipped if an error is raised by the first line from the with block?
+ with self.assertRaises(FileNotFoundError):
+ shutil.chown('invalid-file', user=uid, dir_fd=dirfd)
+ shutil.chown('invalid-file', group=gid, dir_fd=dirfd)
+ shutil.chown('invalid-file', user=uid, group=gid, dir_fd=dirfd)
PCManticore commentedon Jun 27, 2014
I got a failure on FreeBSD:
It seems that either user or group argument must be passed along with dir_fd.
avinassh commentedon Jun 29, 2019
I was looking for an easy patch to submit. I can take an attempt at this?
tahia-khan commentedon Sep 9, 2019
Hi everybody,
I just submitted a PR for this issue. It's my first contribution to the cPython project so please let me know if I need to change anything.