Add StopParser(), ResumeParser, and GetParsingStatus to expat #59979

Activity

1. nemeskeyd commented on Aug 24, 2012

   

   nemeskeydmannequin

   on Aug 24, 2012

   MannequinAuthor

   More actions

   The C expat library provides XML_StopParser() method that allows the parsing to be stopped from the handler functions. It would be nice to have this option in Python as well, maybe by adding StopParser() method to the XMLParser class.
2. nemeskeyd

   added

   topic-XML

   type-featureA feature request or enhancementA feature request or enhancement

   on Aug 24, 2012
3. amauryfa commented on Aug 27, 2012

   

   amauryfa

   on Aug 27, 2012

   Contributor

   More actions

   If a handler function raises an exception, the Parse() method exits and the exception is propagated; internally, this also calls XML_StopParser().
   Why would one call XML_StopParser() explicitely?
4. nemeskeyd commented on Aug 28, 2012

   

   nemeskeydmannequin

   on Aug 28, 2012

   MannequinAuthor

   More actions

   OK, then this issue has a "bug" part, too: it is not mentioned in the documentation that exceptions from the handler methods propagate through the Parse() method. I guess the parser can be then stopped in this way too, but it is a dirty method as opposed to calling StopParser().

   To answer your question, there are several situations where StopParser() could come in handy. For instance, the XML file might contain records (such as the output of a search engine), from which we only need the first n. Another example would be that reading through the file we realize halfway that e.g. it does not contain the information we need, contains wrong information, etc. so we want to skip the rest of it. Since the file might be huge and since XML parsing can in now way be considered fast, being able to stop the parsing in a clear way would spare the superfluous and possible lengthy computation.
5. loewis commented on Aug 28, 2012

   

   loewismannequin

   on Aug 28, 2012

   Mannequin

   More actions

   nemeskeyd: would you like to work on a patch (for Python 3.4)?
6. nemeskeyd commented on Aug 28, 2012

   

   nemeskeydmannequin

   on Aug 28, 2012

   MannequinAuthor

   More actions

   loewis: I don't think it would be difficult to fix, so theoretically I'd be in. However, I don't really have the time to work on this right now.
7. amauryfa commented on Sep 5, 2012

   

   amauryfa

   on Sep 5, 2012

   Contributor

   More actions

   Below is a sample script that shows that it's possible to stop parsing XML in the middle, without an explicit call to XML_StopParser(): raise StopParsing from any handler, and catch it around the Parse() call.

   This method covers the two proposed use cases. Do we need another way to do it?

   import xml.parsers.expat
   
   class StopParsing(Exception):
       pass
   
   def findFirstElementByName(data, what):
     def end_element(name):
         if name == what:
             raise StopParsing(name)
   
     p = xml.parsers.expat.ParserCreate()
     p.EndElementHandler = end_element

   try:
   p.Parse(data, True)
   except StopParsing as e:
   print "Element found:", e
   else:
   print "Element not found"

   data = """<?xml version="1.0"?>
            <parent id="top"><child1 name="paul">Text goes here</child1>
            <child2 name="fred">More text</child2>
            </parent>"""
   findFirstElementByName(data, "child2")   # Found
   findFirstElementByName(data, "child3")   # Not found
8. nemeskeyd commented on Sep 6, 2012

   

   nemeskeydmannequin

   on Sep 6, 2012

   MannequinAuthor

   More actions

   Amaury: see my previous comment. There are two problems with the method you proposed:

   1. It is not mentioned in the documentation that exceptions are propagated through parse().
   2. Exceptions usually mean that an error has happened, and is not the preferred way for flow control (at least this is the policy in other languages e.g. Java, I don't know about Python).
9. amauryfa commented on Sep 6, 2012

   

   amauryfa

   on Sep 6, 2012

   Contributor

   More actions

   Your first point is true, even if the Python zen (try "import this")
   states that "Errors should never pass silently."

   For your second point: exceptions are a common thing in Python code. This is similar to the EAFP principle http://docs.python.org/glossary.html#term-eafp
   Also, this example http://docs.python.org/release/2.7.3/library/imp.html#examples shows that exceptions can be part of the normal flow control.
10. amauryfa

    added

    docsDocumentation in the Doc dirDocumentation in the Doc dir

    on Sep 6, 2012
11. amauryfa

    assigned

    docspython

    on Sep 6, 2012
12. loewis commented on Sep 6, 2012

    

    loewismannequin

    on Sep 6, 2012

    Mannequin

    More actions

    Dávid: Another (similar) example is the Python for loop. In it's original form, it would increase an index and invoke __getitem__ until that *raised* IndexError. In the current definition, it converts the iterated-over object into an iterator, and keeps calling .next until that *raises* StopIteration.

    So raising an exception to indicate that something is finished is an established Python idiom.

    In any case, I still think adding StopParser is a useful addition, in particular since that would also allow giving True as the "resumable" argument. Any such change needs to be accompanied by also exposing XML_ResumeParser, and possibly XML_GetParsingStatus.

    Since we all agree that this is not an important change, I don't mind keeping this issue around until someone comes along to contribute code for it.
13. loewis

    changed the title [-]Add StopParser() to expat[/-] [+]Add StopParser(), ResumeParser, and GetParsingStatus to expat[/+] on Sep 6, 2012
14. ezio-melotti

    transferred this issue fromon Apr 10, 2022