Repository navigation
add support for cjkcodecs to Python email #39645
Description
| BPO | 852347 |
|---|---|
| Nosy | @warsaw |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/warsaw'
closed_at = <Date 2004-05-10.15:04:04.000>
created_at = <Date 2003-12-01.22:05:44.000>
labels = ['type-feature', 'library']
title = 'add support for cjkcodecs to Python email'
updated_at = <Date 2004-05-10.15:04:04.000>
user = 'https://bugs.python.org/jasonrm'bugs.python.org fields:
activity = <Date 2004-05-10.15:04:04.000>
actor = 'barry'
assignee = 'barry'
closed = True
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2003-12-01.22:05:44.000>
creator = 'jasonrm'
dependencies = []
files = ['1124', '1125']
hgrepos = []
issue_num = 852347
keywords = []
message_count = 9.0
messages = ['19221', '19222', '19223', '19224', '19225', '19226', '19227', '19228', '19229']
nosy_count = 2.0
nosy_names = ['barry', 'jasonrm']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue852347'
versions = []
Activity
jasonrm commentedon Dec 1, 2003
As discussed last week on the email-sig
list, the attached patch adds support for
the CJKCodecs package as an alternative
to the {Chinese,Japanese,Korean}Codecs
packages. CJKCodecs 1.0.2 and above
should work with this patch.
This is advantageous because the Chinese
and KoreanCodecs packages are no longer
supported,maintained or available for
download.
This patch does not break compatibility
with {Chinese,Japanese,Korean}Codecs,
so they can still be used if desired.
Lastly, this patch fixes a small typo that
broke GB2312.
warsaw commentedon Dec 29, 2003
Logged In: YES
user_id=12800
Correct me if I'm wrong, but won't the attached patch work
better? It simply removes the entries from CODEC_MAP that
are already provided by cjkcodecs.aliases (and
japanese.aliases and korean.aliases).
See Charset.py.diff
warsaw commentedon Dec 29, 2003
Logged In: YES
user_id=12800
Oops, with the typo fix for gb2312.
warsaw commentedon Dec 29, 2003
Logged In: YES
user_id=12800
One more rev of Charset.py.diff
warsaw commentedon Dec 30, 2003
Logged In: YES
user_id=12800
I'm not even sure this patch is correct, since it breaks the
test suite. The problem is that self.output_codec ends up
being different with the patch than without it (in
Charset.__init__()). For example:
But now with Charset.py.diff applied:
We need to figure out what the right thing to do here is.
jasonrm commentedon Dec 30, 2003
Logged In: YES
user_id=85984
comments regarding Barry's Charset.py.diff:
You shouldn't mention KoreanCodecs and
ChineseCodecs in the comments as
alternatives to CJKCodecs. Both are no
longer maintained, or even available for
download. Both have been completely
replaced by CJKCodecs. Only
JapaneseCodecs remains as a substitute
package.
warsaw commentedon Dec 30, 2003
Logged In: YES
user_id=12800
Latest version of the patch, with updated comments as per
Jason's followup, and including Tokio Kikuchi's fix for the
test suite regression.
warsaw commentedon Dec 30, 2003
Logged In: YES
user_id=12800
Applied to Python trunk (2.4). This will be applied to
Python 2.3 and closed when that branch's freeze is lifted.
warsaw commentedon May 10, 2004
Logged In: YES
user_id=12800
Closing this without applying it to 2.3. The general
consensus was not to mess with this in a bug fix release, so
it will have to wait until Python 2.4/email3.