Skip to content

_PyPegen_add_type_comment_to_arg can fail in _PyPegen_name_default_pair #148157

Closed
Closed
_PyPegen_add_type_comment_to_arg can fail in _PyPegen_name_default_pair#148157
Assignees
StanFromIreland
Labels
interpreter-core(Objects, Python, Grammar, and Parser dirs)topic-parsertype-crashA hard crash of the interpreter, possibly with a core dump

Description

@StanFromIreland
StanFromIreland
opened on Apr 6, 2026

Crash report

What happened?

>>> import _testcapi
>>> _testcapi.Py_CompileStringExFlags(b"def a(f=8,#type: \x80\n\x80", "<test>", 256, 0x0800 | 0x1000)
python: Objects/typeobject.c:2440: type_call: Assertion `!_PyErr_Occurred(tstate)' failed.
Aborted                    (core dumped) ./python

In _PyPegen_name_default_pair, we call:

cpython/Parser/action_helpers.c

Line 437 in a95ee3a

a->arg = _PyPegen_add_type_comment_to_arg(p, arg, tc);

but don't check if it failed (and returned NULL).

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Output from running 'python -VV' on the command line:

No response

Linked PRs

Activity

  1. StanFromIreland
    self-assigned this
    on Apr 6, 2026
  2. StanFromIreland
    added
    type-crashA hard crash of the interpreter, possibly with a core dump
    interpreter-core(Objects, Python, Grammar, and Parser dirs)
    topic-parser
    on Apr 6, 2026
  3. StanFromIreland
    added a commit that references this issue on Apr 6, 2026

    gh-148157: Check for `_PyPegen_add_type_comment_to_arg` fail in `_Py…

    1795fcc
  4. miss-islington
    added 2 commits that reference this issue on Apr 6, 2026

    pythongh-148157: Check for `_PyPegen_add_type_comment_to_arg` fail in…

    81fe44b

    pythongh-148157: Check for `_PyPegen_add_type_comment_to_arg` fail in…

    59c99be
  5. StanFromIreland
    added a commit that references this issue on Apr 6, 2026

    [3.13] gh-148157: Check for `_PyPegen_add_type_comment_to_arg` fail i…

    4dfcdbe
  6. StanFromIreland
    closed this as completedon Apr 6, 2026
  7. StanFromIreland
    added a commit that references this issue on Apr 6, 2026

    [3.14] gh-148157: Check for `_PyPegen_add_type_comment_to_arg` fail i…

    40a0a94
  8. ljfp
    added a commit that references this issue on Apr 25, 2026

    pythongh-148157: Check for `_PyPegen_add_type_comment_to_arg` fail i…

    85cece2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

interpreter-core(Objects, Python, Grammar, and Parser dirs)topic-parsertype-crashA hard crash of the interpreter, possibly with a core dump

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions