PyType_GetModuleByDef can return NULL without exception set

[iritkatriel]

The documentation does not mention that this is possible, but if the object passed in is not a heap type it returns NULL without setting an exception:

PyObject *
PyType_GetModuleByDef(PyTypeObject *type, PyModuleDef *def)
{
    assert(PyType_Check(type));   

    if (!_PyType_HasFeature(type, Py_TPFLAGS_HEAPTYPE)) {
        // type_ready_mro() ensures that no heap type is
        // contained in a static type MRO.
        return NULL;
    }
   ...
}

CC @ericsnowcurrently @encukou .

Linked PRs

• gh-133166: Fix missing error emission of PyType_GetModuleByDef #133240

[encukou]

Thanks for the catch, and thanks @neonene for the quick fix!

[neonene]

cpython/Objects/typeobject.c

Lines 5015 to 5020 in 90c786e

	PyType_GetModuleByDef(PyTypeObject *type, PyModuleDef *def)
	{
	PyObject *module = get_module_by_def(type, def);
	if (module == NULL) {
	PyErr_Format(
	PyExc_TypeError,

3.13 has no issue. The test for 3.14 cannot be backported.

[encukou]

Ah! My mistake

[neonene]

Thank you for the report and the review.