-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
Update bundled setupotools in test.wheeldata
and remove wheel.whl
#132415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Do tests fail with different versions of |
With the new |
Adding/updating binary artefacts increases the repository size, with little observable/user benefit in this case (a test file). It might be easier just to do the update though, we will probably see more 'update' PRs (such as @hroncok's #132867, which I imagine was inadvertant -- it took me a couple of minutes to find this issue again). A |
test.wheeldata
and remove wheel.whl
Sorry for the duplicate issue and PR. I did not find this one. Here is my rationale from #132866 In Fedora, we use our own setuptools and wheel wheels from wheel 0.45+ now depends on packaging pypa/wheel#655 Since we would like to update our wheel and we already updated setuptools to a version that does not require wheel to create wheels, I was wondering whether we could update setuptools in https://github.com/python/cpython/tree/main/Lib/test/wheeldata to 70.1+ and drop the wheel.whl. That would make it easier for us to update. |
Ok. I've opened a new PR, as A |
Thanks |
…ldata`` (cherry picked from commit c9f3f5b) (actual changes in .whl files removed to make this patch smaller)
…eldata`` (python#132887)" This reverts commit c9f3f5b.
test_cppext started to fail with this change:
I merged #132902 to fix the regression. In fact, the bug was already there before, but the setuptools update caused the regression. It's unclear to me how the code worked before that. Note: @AA-Turner wrote the same fix than me 4 minutes later, but I merged my fix instead. |
…ldata`` (cherry picked from commit c9f3f5b) (actual changes in .whl files removed to make this patch smaller) pythongh-127906: Add missing sys import to test_cppext (cherry picked from commit 9cba148) Co-Authored-By: Victor Stinner <vstinner@python.org>
Replace deprecated distutils.spawn.find_executable() with shutil.which() in missing_compiler_executable() of test.support.
Replace deprecated distutils.spawn.find_executable() with shutil.which() in missing_compiler_executable() of test.support.
…ythonGH-132906) Replace deprecated distutils.spawn.find_executable() with shutil.which() in missing_compiler_executable() of test.support. (cherry picked from commit de6482e) Co-authored-by: Victor Stinner <vstinner@python.org>
…GH-132906) (#132916) gh-132415: Use shutil.which() in missing_compiler_executable() (GH-132906) Replace deprecated distutils.spawn.find_executable() with shutil.which() in missing_compiler_executable() of test.support. (cherry picked from commit de6482e) Co-authored-by: Victor Stinner <vstinner@python.org>
More side effects of the change:
|
Thanks all! |
Bug report
Bug description:
test.wheeldata
includes bundledsetuptools
andwheel
wheels to build packages. Sincesetuptools>=0.70.1
, thebdist_wheel
method is natively included in setuptools, and there's no necessity to have thewheel
library available, to build wheels any more.Relatedly,
wheel>=0.46.0
de-vendored thepackaging
library, so current versions ofwheel
can't be used without havingpackaging
available too.CPython versions tested on:
CPython main branch
Operating systems tested on:
Linux
Linked PRs
Lib/test/wheeldata
#132887Lib/test/wheeldata
(#132887)" #132900The text was updated successfully, but these errors were encountered: