Skip to content

JIT: remove jumps at the end of every micro op on aarch64 #130887

Closed
Closed
JIT: remove jumps at the end of every micro op on aarch64#130887
Assignees
diegorusso
Labels
3.14bugs and security fixesinterpreter-core(Objects, Python, Grammar, and Parser dirs)performancePerformance or resource usagetopic-JITtriagedThe issue has been accepted as valid by a triager.

Description

@diegorusso
diegorusso
opened on Mar 5, 2025

Feature or enhancement

Bug description:

AArch64 JIT stencils contain a jump at the end of every micro op:

...
    // d4: a8c17bfd      ldp     x29, x30, [sp], #0x10
    // d8: 14000000      b       0xd8 <_JIT_ENTRY+0xd8>
    // 00000000000000d8:  R_AARCH64_JUMP26     _JIT_CONTINUE

These jumps need to be removed and replaced with no-ops to keep the alignment of 8 bytes.
Also the current padding mechanism needs to be removed as well.

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs

Activity

  1. diegorusso
    added
    topic-JIT
    type-featureA feature request or enhancement
    on Mar 5, 2025
  2. diegorusso
    self-assigned this
    on Mar 5, 2025
  3. brandtbucher
    added
    performancePerformance or resource usage
    interpreter-core(Objects, Python, Grammar, and Parser dirs)
    3.14bugs and security fixes
    and removed
    type-featureA feature request or enhancement
    on Mar 5, 2025
  4. picnixz
    added
    triagedThe issue has been accepted as valid by a triager.
    on Mar 7, 2025
  5. diegorusso
    added a commit that references this issue on Mar 10, 2025

    pythongh-130887: remove trailing jump in AArch64 JIT stencils

    46093f8
  6. brandtbucher
    added a commit that references this issue on Mar 25, 2025

    GH-130887: Always remove trailing jumps in AArch64 JIT stencils (GH-1…

    ea0453e
  7. brandtbucher
    closed this as completedon Mar 25, 2025
  8. diegorusso
    added a commit that references this issue on Apr 1, 2025

    pythonGH-130887: Always remove trailing jumps in AArch64 JIT stencils (…

    3d295c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

3.14bugs and security fixesinterpreter-core(Objects, Python, Grammar, and Parser dirs)performancePerformance or resource usagetopic-JITtriagedThe issue has been accepted as valid by a triager.

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions