Repository navigation
gh-130693: Add options of the tkinter.Text.search method: -nolinestop -all -overlap -strictlimits - #130848
Merged
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Wulian233
reviewed
Mar 5, 2025
Wulian233
reviewed
May 5, 2025
ZeroIntensity
left a comment
Member
There was a problem hiding this comment.
All new features need tests. Please add one to test_tkinter.
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Member
|
Thanks! Shoot for the stars :) |
Added tests for text.search with and without regex.
Refactor test_search_all to simplify assertions and update overlap checks.
Contributor
Author
|
@serhiy-storchaka Ready for review |
serhiy-storchaka
enabled auto-merge (squash)
November 17, 2025 14:10
serhiy-storchaka
pushed a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Nov 17, 2025
|
GH-141669 is a backport of this pull request to the 3.14 branch. |
Member
|
Thank you for your contribution, @sharktide. I rewrote the tests, so they clearly test the new options, and added many tests for already supported options. These tests will be backported. |
serhiy-storchaka
added a commit
that referenced
this pull request
Nov 17, 2025
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 17, 2025
…honGH-130848) (pythonGH-141669) (cherry picked from commit 8db1aad) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka
added a commit
that referenced
this pull request
Nov 17, 2025
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
…honGH-130848) * Add parameters nolinestop and strictlimits in the tkinter.Text.search() method. * Add the tkinter.Text.search_all() method. * Add more tests for tkinter.Text.search(). * stopindex is now only ignored if it is None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add options -nolinestop, -all, -overlap, and -strictlimits to the search function of the text class of tkinter.
Fixes #130693
Closes #130693
Tested against
And test passed. Result:
Also tested against a custom test file:
[EDITED for change to new search_all method for -all and -overlap]
Which returns:
Indicating that the new features are functioning correctly