typing.evaluate_forward_ref is not fully covered

Right now it is:

I have a PR ready.

Linked PRs

Aaaand I found a bug!

Lines 1021 to 1030 in a1284e9

    
           def evaluate_forward_ref( 
        
               forward_ref, 
        
               *, 
        
               owner=None, 
        
               globals=None, 
        
               locals=None, 
        
               type_params=None, 
        
               format=annotationlib.Format.VALUE, 
        
               _recursive_guard=frozenset(), 
        
           ):

type_params here is None, not _sentinel, so the deprecation warning is never shown.

pythongh-128661: Fix `typing.evaluate_forward_ref` not showing deprec…

gh-128661: Fix `typing.evaluate_forward_ref` not showing deprecation (#…

pythongh-128661: Remove DeprecationWarning in evaluate_forward_ref

gh-128661: Remove DeprecationWarning in evaluate_forward_ref (#128930)

Navigation Menu

Repository navigation

`typing.evaluate_forward_ref` is not fully covered #128661

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	def evaluate_forward_ref(
	forward_ref,
	*,
	owner=None,
	globals=None,
	locals=None,
	type_params=None,
	format=annotationlib.Format.VALUE,
	_recursive_guard=frozenset(),
	):

typing.evaluate_forward_ref is not fully covered #128661

Description

Linked PRs

Activity

sobolevn commented on Jan 9, 2025

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

`typing.evaluate_forward_ref` is not fully covered #128661