Skip to content

_Py_RefcntAdd doesn't increment ref count stats #127599

Closed
#127717
Closed
_Py_RefcntAdd doesn't increment ref count stats#127599
#127717
Labels
interpreter-core(Objects, Python, Grammar, and Parser dirs)type-bugAn unexpected behavior, bug, or error

Description

@EdNutting
EdNutting
opened on Dec 4, 2024

Bug report

Bug description:

Hi,

I am unsure if this intentional or not so apologies if this turns out not to be a bug.

The code for _Py_RefcntAdd does not include _Py_INCREF_STAT_INC. This appears to mean the statistics do not track these additions to the reference count, which are increments (although not increments by 1, they are increasing the ref count in a single operation).

cpython/Include/internal/pycore_object.h

Line 121 in ad9d059

static inline void _Py_RefcntAdd(PyObject* op, Py_ssize_t n)

I believe this may be an oversight because this stat should be tracked, and also because the corresponding decrement ref count code does call _Py_DECREF_STAT_INC (e.g.

cpython/Include/internal/pycore_object.h

Line 383 in ad9d059

_Py_DECREF_STAT_INC();
)

I have checked the callers of _Py_RefcntAdd (in listobject.c and tupleobject.c) and they do not separately perform the stats tracking.

Is this an issue or is there a reason this ref count increment is excluded?

Thanks,
Ed

CPython versions tested on:

3.12, 3.13

Operating systems tested on:

Linux, macOS

Linked PRs

Activity

  1. EdNutting
    added
    type-bugAn unexpected behavior, bug, or error
    on Dec 4, 2024
  2. Eclips4
    added
    interpreter-core(Objects, Python, Grammar, and Parser dirs)
    on Dec 4, 2024

  3. ZeroIntensity commented on Dec 4, 2024

    @ZeroIntensity
    ZeroIntensity
    on Dec 4, 2024
    Member

    Looks like a bug. We're missing _Py_INCREF_IMMORTAL_STAT_INC for immortal objects as well.

  4. EdNutting commented on Dec 4, 2024

    @EdNutting
    EdNutting
    on Dec 4, 2024
    ContributorAuthor

    Thank you for such a quick reply! I'll try to clone CPython separately to create a PR to fix these over the next few days.

  5. Eclips4
    added a commit that references this issue on Dec 15, 2024

    gh-127599: Fix _Py_RefcntAdd missing calls to _Py_INCREF_STAT_INC/_Py…

    ab05beb
  6. Eclips4
    closed this as completedin #127717on Dec 15, 2024
  7. miss-islington
    added a commit that references this issue on Dec 15, 2024

    pythongh-127599: Fix _Py_RefcntAdd missing calls to _Py_INCREF_STAT_I…

    0f72cdb
  8. srinivasreddy
    added a commit that references this issue on Jan 8, 2025

    pythongh-127599: Fix _Py_RefcntAdd missing calls to _Py_INCREF_STAT_I…

    f705e98
  9. EdNutting
    added 3 commits that reference this issue on Jan 10, 2025

    [3.13] pythongh-127599: Fix _Py_RefcntAdd missing calls to _Py_INCREF…

    238944a

    [3.13] pythongh-127599: Fix _Py_RefcntAdd missing calls to _Py_INCREF…

    ed624be

    [3.13] pythongh-127599: Fix _Py_RefcntAdd missing calls to _Py_INCREF…

    e7dd078
  10. Eclips4
    added 2 commits that reference this issue on Jan 18, 2025

    [3.12] gh-127599: Fix _Py_RefcntAdd missing calls to _Py_INCREF_STAT_…

    bca4890

    [3.13] gh-127599: Fix _Py_RefcntAdd missing calls to _Py_INCREF_STAT_…

    fdac362

  11. Eclips4 commented on Jan 18, 2025

    @Eclips4
    Eclips4
    on Jan 18, 2025
    Member

    Thank you @EdNutting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    interpreter-core(Objects, Python, Grammar, and Parser dirs)type-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions