Improve the performance of ntpath.expanduser() #117686
Description
Feature or enhancement
Proposal:
In ntpath.expanduser(), _get_bothseps() is called in every loop iteration. It should be assigned instead:
if isinstance(path, bytes):
+ seps = b'\\/'
tilde = b'~'
else:
+ seps = '\\/'
tilde = '~'
if not path.startswith(tilde):
return path
i, n = 1, len(path)
-while i < n and path[i] not in _get_bothseps(path):
+while i < n and path[i] not in seps:
i += 1Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Activity
[-]Move `_get_bothseps()` outside loop condition[/-][+]Improve the performance of ntpath.expanduser()[/+]terryjreedy commentedon Apr 10, 2024
To me, this is a clearly better.
gh-117686: Improve the performance of ntpath.expanduser() (#117690)
erlend-aasland commentedon Apr 10, 2024
Thanks!
pythongh-117686: Improve the performance of ntpath.expanduser() (pyth…