Skip to content

GetLastError() not preserved across GIL operations on Windows #116012

Description

@zooba

Bug report

Changes to TLS usage in 3.13 may cause the last error code to be reset when ensuring, checking or releasing the GIL. We need to preserve the value.

PyGILState_Check was already updated, but the other public APIs need the same update. Potentially some of our internal/public ones too. It might just be best to add it to the PyThread_tss_* functions.

Linked PRs

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

3.13bugs and security fixestype-bugAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions