invalid_def_raw and invalid_class_def_raw rules do not account for type parameters

[MatthieuDartiailh]

Bug report

Bug description:

The rules which are affected are here:

cpython/Grammar/python.gram

Line 1371 in 6a4528d

invalid_def_raw:

Typically I believe they should read

invalid_def_raw:
    | ['async'] a='def' NAME [type_params] '(' [params] ')' ['->' expression] ':' NEWLINE !INDENT {
        RAISE_INDENTATION_ERROR("expected an indented block after function definition on line %d", a->lineno) }
invalid_class_def_raw:
    | 'class' NAME [type_params] ['(' [arguments] ')'] NEWLINE { RAISE_SYNTAX_ERROR("expected ':'") }
    | a='class' NAME [type_params] ['(' [arguments] ')'] ':' NEWLINE !INDENT {
        RAISE_INDENTATION_ERROR("expected an indented block after class definition on line %d", a->lineno) }

to allow proper error reporting if the definition uses type parameters.

CPython versions tested on:

3.12

Operating systems tested on:

No response

Linked PRs

• gh-110938: Fix error messages for indented blocks with functions and classes with generic type parameters #110973
• gh-110938: Add several missing syntax tests for PEP695 funcs and classes #110986
• [3.12] gh-110938: Fix error messages for indented blocks with functio… #110990
• [3.12] gh-110938: More syntax tests for PEP695 funcs and classes (GH-110986) #111023

[Eclips4]

cc @pablogsal @lysnikolaou and @JelleZijlstra as author of implementation of PEP 695

[pablogsal]

Will make a pr today

[sobolevn]

Sorry for being late with the review, but there are several test cases that are missing from @pablogsal's PR. I've opened a new one to address this case:

• before:

>>> class A[T]
  File "<stdin>", line 1
    class A[T]
              ^
SyntaxError: invalid syntax
>>> class A[T]()
  File "<stdin>", line 1
    class A[T]()
                ^
SyntaxError: invalid syntax

• after:

>>> class A[T]
  File "<stdin>", line 1
    class A[T]
              ^
SyntaxError: expected ':'
>>> class A[T]()
  File "<stdin>", line 1
    class A[T]()
                ^
SyntaxError: expected ':'

It is fixed, but not tested 👍