Repository navigation
flowgraph optimize_cfg Assertion for if-else-expression with if-else-expression as condition #109889
Description
Bug report
Bug description:
a if (1 if b else c) else doutput (Python 3.12.0rc3+):
python: Python/flowgraph.c:1598: optimize_cfg: Assertion `no_redundant_nops(g)' failed.tested with the current 3.12 branch (538f505)
CPython versions tested on:
3.12
Operating systems tested on:
Linux
Linked PRs
- [3.12] gh-109889: comment out assertion indicating a failed optimization of a redundant NOP #109899
- gh-109889: fix compiler's redundant NOP detection to look past NOPs with no lineno when looking for the next instruction's lineno #109987
- [3.12] gh-109889: fix compiler's redundant NOP detection to look past NOPs with no lineno when looking for the next instruction's lineno (GH-109987) #110048
Activity
AA-Turner commentedon Sep 26, 2023
cc: @iritkatriel
iritkatriel commentedon Sep 26, 2023
The optimizer removes NOPs which are redundant (don't have important line number info attached). But there is a bug where it misses the case where there is a basic block that contains a single such NOP (and nothing else).
This is not a correctness issue, it's only an optimization failing. I will make a PR for 3.12 to just remove the assertion. In 3.13 I will fix this optimization.
iritkatriel commentedon Sep 26, 2023
I mean remove the assertion in 3.12.0. We can fix in 3.12.1.
[3.12] pythongh-109889: comment out assertion indicating a failed opt…
[3.12] gh-109889: comment out assertion indicating a failed optimizat…
pythongh-109889: fix redundant NOP detection to look past NOPs with n…
pythongh-109889: fix redundant NOP detection to look past NOPs with n…
pythongh-109889: fix redundant NOP detection to look past NOPs with n…
pythongh-109889: fix redundant NOP detection to look past NOPs with n…
Merge branch 'main' into pythongh-109889
gh-109889: fix compiler's redundant NOP detection to look past NOPs w…
pythongh-109889: fix compiler's redundant NOP detection to look past …
pythongh-109889: fix compiler's redundant NOP detection to look past …
[3.12] gh-109889: fix compiler's redundant NOP detection to look past…
pythongh-109889: fix compiler's redundant NOP detection to look past …