Repository navigation
Build fails with recent libedit versions #109191
Description
Bug report
Bug description:
readline_set_completion_display_matches_hook_impl will use either VFunction (if _RL_FUNCTION_TYPEDEF is defined) or rl_compdisp_func_t. The former is deprecated but available in current readline, while the latter has historically not been available in libedit. However, libedit recently added rl_compdisp_func_t and removed VFunction entirely: http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/libedit/readline/readline.h.diff?r1=1.53&r2=1.54&sortby=date
We ship a recent libedit in MacPorts, so we see a compilation failure like this:
./Modules/readline.c:448:10: error: use of undeclared identifier 'VFunction'; did you mean 'function'?
(VFunction *)on_completion_display_matches_hook : 0;
^~~~~~~~~
It's easy enough for us to patch around this, but I guess if compatibility with both current libedit and the older version shipped by Apple is desired, there needs to be another check for the availability of this type.
CPython versions tested on:
3.12
Operating systems tested on:
macOS
Activity
corona10 commentedon Sep 10, 2023
see also: #105323
corona10 commentedon Sep 10, 2023
And about the apple workaround: #108665
[3.11] pythongh-109191: Fix build with newer editline
pythongh-109191: Fix build with newer editline
gh-109191: Fix build with newer editline (gh-110239)
pythongh-109191: Fix build with newer editline (pythongh-110239)
[3.12] gh-109191: Fix build with newer editline (gh-110239) (gh-110562)
[3.11] pythongh-109191: Fix build with newer editline (pythongh-110239).
[3.11] gh-109191: Fix build with newer editline (gh-110239) (#110575)
erlend-aasland commentedon Oct 9, 2023
Thanks for the report, @jmroot, thanks for the PR, @Bo98, and thanks for the review, @corona10 :)
Marking this as resolved.
(3.11 backport is approved and will be automerged)
pythongh-109191: Fix build with newer editline (pythongh-110239)