Streamline family syntax in Tools/cases_generator

The syntax to designate a family currently looks like this:

        family(store_subscr, INLINE_CACHE_ENTRIES_STORE_SUBSCR) = {
            STORE_SUBSCR,
            STORE_SUBSCR_DICT,
            STORE_SUBSCR_LIST_INT,
        };

Here the store_subscr "family name" is redundant (and in fact we even had one case where it was incorrect).

I propose to change it to be more similar to the pseudo syntax, so it will become

        family(STORE_SUBSCR, INLINE_CACHE_ENTRIES_STORE_SUBSCR) = {
            STORE_SUBSCR_DICT,
            STORE_SUBSCR_LIST_INT,
        };

This should be a straightforward change to the parser and code generator in Tools/cases_generator.

Linked PRs

gh-106706: Streamline family syntax #106716

Where I find thet code?

In Tools/cases_generator/. The example is in Python/bytecodes.c.

pythongh-106706 Streamline family syntax

I started working on this here: https://github.com/kgdiem/cpython/tree/streamline-family-syntax

I think the correct course of action to change the validations check_families[1] (decrement member length requirement, ensure name is in the macro instructions) and make some simple updates to write_metadata[2] ingenerate_cases.py.

Is that correct?

[1] https://github.com/python/cpython/blob/main/Tools/cases_generator/generate_cases.py#L809
[2] https://github.com/python/cpython/blob/main/Tools/cases_generator/generate_cases.py#L1171

@kgdiem

@kgdiem You got it!

@kgdiem

@kgdiem You got it!

Awesome! I had one question about changing one of the tests in my PR but I saw you opened another issue wrt them being broken ...

#105540

~~If you are ready for a review of your code, just make a PR and CC me.~~ [Sorry, realized you already did. Reviewing now.]

pythongh-106706 Streamline family syntax

gh-106706: Streamline family syntax in cases generator DSL (#106716)

@kgdiem

@kgdiem Thanks for your contribution! You're welcome to help out more any time.

@kgdiem

@kgdiem Thanks for your contribution! You're welcome to help out more any time.

Thanks! I'm interested in spending 5-10 hours/week working on Python/Python ecosystem but having some trouble finding another issue I can pick up.

Thanks! I'm interested in spending 5-10 hours/week working on Python/Python ecosystem but having some trouble finding another issue I can pick up.

Cool. May I inquire what motivates you to do this? And what kind of issues are you looking for? Can they involve C code?

May I inquire what motivates you to do this?

I enjoy it! I code as a hobby (and professionally) and want to do something beyond web development; high perf, systems programming, applied CS, etc

And what kind of issues are you looking for? Can they involve C code?

Ya. I started looking at the last issue you'd opened (gh-106608) but was a bit intimidated and was trying to find something "easier" / more in my traditional wheelhouse.

In thinking about my reply here, re-reviewing the issue & related the code, I'm pretty confident and am going to give it a shot. I'll reach out over there if I need any help.

Thanks again.

Cool, see you at that issue. Be sure not to bang your head against the wall for too long -- ask for help before it starts bleeding! :-)

Small fixes to code generator (#106845)

Navigation Menu

Repository navigation

Streamline family syntax in Tools/cases_generator #106706

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Streamline family syntax in Tools/cases_generator #106706

Description

Linked PRs

Activity

DanielFrantes commented on Jul 13, 2023

gvanrossum commented on Jul 13, 2023

kgdiem commented on Jul 13, 2023

gvanrossum commented on Jul 13, 2023

kgdiem commented on Jul 13, 2023

gvanrossum commented on Jul 13, 2023

gvanrossum commented on Jul 16, 2023

kgdiem commented on Jul 17, 2023

gvanrossum commented on Jul 17, 2023

kgdiem commented on Jul 17, 2023

gvanrossum commented on Jul 17, 2023

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions