You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
New deprecation warning in some tests due to a new decorator in test.support #101167
DeprecationWarning: It is deprecated to return a value that is not None from a test case (<bound method _id of <test.test_dis.DisTests testMethod=test_binary_specialize>>)
Shows up in test_dis, test_compile and test_embed, for tests that use the new @requires_specialization which was added in #100713.
I don't know why this decorator does this while requires_limited_api doesn't.
line 1082 should end with (test). As is, any test decorated with that decorator is disabled completely; the test is set to the skipUnless decorator, not the decorated test.
Activity
zware commentedon Jan 19, 2023
At
cpython/Lib/test/support/__init__.py
Lines 1081 to 1082 in 8a2d4f4
line 1082 should end with
(test). As is, any test decorated with that decorator is disabled completely; the test is set to theskipUnlessdecorator, not the decorated test.iritkatriel commentedon Jan 19, 2023
Ah yes, thanks. Are you making a PR or shall I?
zware commentedon Jan 19, 2023
All yours :)
pythongh-101167: fix bug in the new test.support.requires_specializat…
iritkatriel commentedon Jan 19, 2023
It's a good deprecation warning!
gh-101167: fix bug in the new test.support.requires_specialization de…