Skip to content

Ensurepip fails ungracefully when mimetype is missing from Windows registry  #100256

Closed
Closed
Ensurepip fails ungracefully when mimetype is missing from Windows registry #100256
Labels
3.12only security fixes3.13only security fixes3.14bugs and security fixesOS-windowseasyextension-modulesC modules in the Modules dirtopic-ensurepiptriagedThe issue has been accepted as valid by a triager.type-bugAn unexpected behavior, bug, or error

Description

@BlipRanger
BlipRanger
opened on Dec 14, 2022

Bug report

A "WinError 5 Access is denied" error occurs when ensurepip (for python 3.10 and above) is run and there are missing/inaccessible mimetypes in the Windows registry. Because ensurepip is used in the Python installer, it also fails silently there, causing pip to never be installed without alerting the user to the issue. The line in which the error occurs is here:

cpython/Lib/mimetypes.py

Line 250 in 024ac54

_mimetypes_read_windows_registry(add_type)

Bypassing that line and instead using self._read_windows_registry(add_type) (which is the fallback function I believe) fixes the problem. I believe that _mimetypes_read_windows_registry(add_type) needs to be able to fail more gracefully when it can't find a particular mimetype in the registry.
I found someone else describing exactly the issue here.

Your environment

  • CPython versions tested on: 3.10, 3.11
  • Operating system and architecture: Windows 10 LTSC, x64

Linked PRs

Activity

  1. BlipRanger
    added
    type-bugAn unexpected behavior, bug, or error
    on Dec 14, 2022
  2. eryksun
    added
    OS-windows
    extension-modulesC modules in the Modules dir
    3.11only security fixes
    3.10 (EOL)end of life
    3.12only security fixes
    on Dec 14, 2022
  3. pradyunsg
    added
    topic-ensurepip
    on Feb 21, 2023

  4. huanghe2015 commented on Aug 4, 2023

    @huanghe2015
    huanghe2015
    on Aug 4, 2023

    Same thing happened with me ,Patrick and Stackoverflow.

  5. eryksun
    added
    3.13only security fixes
    3.14bugs and security fixes
    easy
    triagedThe issue has been accepted as valid by a triager.
    and removed
    3.11only security fixes
    3.10 (EOL)end of life
    on Jun 18, 2024
  6. LucasEsposito
    added 3 commits that reference this issue on Jul 19, 2024

    pythongh-100256: Read Windows registry with the fallback implementati…

    0ffc526

    pythongh-100256: Skip inaccessible registry keys in the WinAPI implem…

    7b2e83b

    pythongh-100256: Skip inaccessible registry keys in the mimetype WinA…

    6922a1d

  7. LucasEsposito commented on Jul 19, 2024

    @LucasEsposito
    LucasEsposito
    on Jul 19, 2024
    Contributor

    Opened a PR to address this issue

  8. LucasEsposito
    added 2 commits that reference this issue on Jul 21, 2024

    Merge branch 'main' into pythongh-100256-denied_access_to_windows_mim…

    78a4bad

    pythongh-100256: Skip inaccessible registry keys in the mimetype WinA…

    f70f185
  9. zooba
    added a commit that references this issue on Aug 7, 2024

    gh-100256: Skip inaccessible registry keys in the WinAPI mimetype imp…

    0bd9375
  10. miss-islington
    added 2 commits that reference this issue on Aug 7, 2024

    pythongh-100256: Skip inaccessible registry keys in the WinAPI mimety…

    b8950cb

    pythongh-100256: Skip inaccessible registry keys in the WinAPI mimety…

    00f3e4c
  11. zooba
    added a commit that references this issue on Aug 7, 2024

    gh-100256: Skip inaccessible registry keys in the WinAPI mimetype imp…

    8f4892a
  12. blhsing
    added a commit that references this issue on Aug 22, 2024

    pythongh-100256: Skip inaccessible registry keys in the WinAPI mimety…

    b99701a
  13. Yhg1s
    added a commit that references this issue on Sep 2, 2024

    [3.13] gh-100256: Skip inaccessible registry keys in the WinAPI mimet…

    f070398

  14. hugovk commented on Nov 18, 2024

    @hugovk
    hugovk
    on Nov 18, 2024
    Member

    Triage: Closing, PRs have been merged and backported.

  15. hugovk
    closed this as completedon Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.12only security fixes3.13only security fixes3.14bugs and security fixesOS-windowseasyextension-modulesC modules in the Modules dirtopic-ensurepiptriagedThe issue has been accepted as valid by a triager.type-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions