Repository navigation
Passing folium.Icon to folium.Marker seems to be broken on main #2084
Description
GeoPandas CI is failing with Folium main due to the icon passed to the marker no longer being used.
import folium
fc = {'type': 'FeatureCollection',
'features': [{'id': '0',
'type': 'Feature',
'properties': {'name': 'Vatican City'},
'geometry': {'type': 'Point', 'coordinates': (12.4533865, 41.9032822)},
'bbox': (12.4533865, 41.9032822, 12.4533865, 41.9032822)}],
'bbox': (12.4533865, 41.9032822, 12.4533865, 41.9032822)}
m = folium.Map()
marker = folium.Marker(icon=folium.Icon(icon="star"))
folium.GeoJson(
fc,
marker=marker,
).add_to(m)
mThis creates a marker with a star symbol in folium 0.19.4 but uses default on main.
Activity
Conengmo commentedon Jan 24, 2025
Sorry about that Martin! I made a fix that should hopefully solve this issue.
LukasWallisch commentedon Mar 13, 2025
Shouldn't this be fixed in 0.19.5 ?
For me it still is there in this Version 🙃
Conengmo commentedon Mar 15, 2025
Hi @LukasWallisch, I tried the example Martin posted in the OP with Folium 0.19.5 and Geopandas 1.0.1 and it works. If it doesn't work for you, could you maybe share a complete reproducible example that leads to your issue?
martinfleis commentedon Mar 15, 2025
Yeah,can confirm that the issue GeoPandas was facing has been fixed.