Skip to content

No popup when clicking on specific icons (BeautifyIcon plugin) #1948

Description

@EmanuelCastanho

Hi!

I was checking the BeautifyIcon plugin demo and I don't understand why when I click on the plane icon the popup doesn't show up.
Here is the example: https://python-visualization.github.io/folium/latest/user_guide/plugins/beautify_icon.html

Is this a font-awesome related problem?

Activity

  1. hansthen commented on May 14, 2024

    @hansthen
    Collaborator

    I can confirm the issue. In the browser console I see the following stack trace:

    Uncaught TypeError: Cannot read properties of undefined (reading 'x')
        at p._add (Point.js:55:19)
        at p.add (Point.js:50:23)
        at e._updatePosition (DivOverlay.js:303:45)
        at e.update (DivOverlay.js:189:8)
        at e.onAdd (DivOverlay.js:113:8)
        at e.onAdd (Popup.js:135:30)
        at e._layerAdd (Layer.js:114:8)
        at e.whenReady (Map.js:1477:13)
        at e.addLayer (Layer.js:172:8)
        at e.openOn (DivOverlay.js:63:8)
    
  2. EmanuelCastanho commented on May 17, 2024

    @EmanuelCastanho
    Author

    I think the problem is inside Point.js, here:

    _add: function (point) {
        // destructive, used directly for performance in situations where it's safe to modify existing point
        this.x += point.x;
        this.y += point.y;
        return this;
    },
    

    At least according to the console.

  3. added
    bugAn issue describing unexpected or malicious behaviour
    pluginThis issue/PR is about an existing or new plugin
    on May 18, 2024
  4. changed the title [-]No popup when clicking on specific icons[/-] [+]No popup when clicking on specific icons (BeautifyIcon plugin)[/+] on May 18, 2024
  5. EmanuelCastanho commented on Jun 11, 2024

    @EmanuelCastanho
    Author

    Any suggestions on how to solve this?

  6. Conengmo commented on Jun 16, 2024

    @Conengmo
    Member

    This is likely an issue with the underlying Leaflet plugin we wrap around: https://github.com/masajid390/BeautifyMarker. Someone would have to go look at that library and see what the issue is. My theory would be that Leaflet updated something somewhere in the last few years that broke the behavior for this plugin.

  7. added
    not our bugThe bug cannot be fixed in folium but needs to be solved somewhere else
    and removed
    bugAn issue describing unexpected or malicious behaviour
    on Jun 16, 2024
  8. thisisvk45 commented on Jul 25, 2024

    @thisisvk45

    The popup issue with the BeautifyIcon plugin demo is due to an undefined point in Point.js during the _add function call, likely caused by a Leaflet update that broke compatibility with the BeautifyMarker plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    not our bugThe bug cannot be fixed in folium but needs to be solved somewhere elsepluginThis issue/PR is about an existing or new plugin

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions