Skip to content

Conversation

@sydney-runkle
Copy link
Contributor

@sydney-runkle sydney-runkle commented Oct 20, 2023

Change Summary

Support validate call decorator for methods in classes with __slots__

Related issue number

Fix #7466

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @lig

@sydney-runkle
Copy link
Contributor Author

Please review

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 101f730
Status: ✅  Deploy successful!
Preview URL: https://92fcd84b.pydantic-docs2.pages.dev
Branch Preview URL: https://support-val-call-with-slots.pydantic-docs2.pages.dev

View logs

@sydney-runkle sydney-runkle added the relnotes-fix Used for bugfixes. label Oct 20, 2023
@sydney-runkle sydney-runkle merged commit 4dd40ae into main Oct 20, 2023
@sydney-runkle sydney-runkle deleted the support-val-call-with-slots branch October 20, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@validate_call on instance method of class with __slots__ raises "AttributeError: object attribute is read-only"

4 participants