Skip to content

Invalid query strings cause exceptions #43

Open

Description

@bklaric

Hyper uses decodeURIComponent to parse query string. However, decodeURIComponent has an incorrect type as documented here, since it throws an exception on invalid input.

I'm unsure whether it would be better to wait for the related issue to be resolved or to use something else for decoding strings.

Activity

  1. owickstrom commented on Sep 4, 2017

    @owickstrom
    Collaborator

    Yeah, maybe we should switch over to https://pursuit.purescript.org/packages/purescript-uri/4.0.0/docs/Data.URI.Query. I just skimmed it, but it seems to be the corresponding thing, but with a safe parser and type.

  2. bklaric commented on Sep 4, 2017

    @bklaric
    ContributorAuthor

    Thanks, I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions