Debugger continues to work despite Sketch name and folder name are not equal#1197
Debugger continues to work despite Sketch name and folder name are not equal#1197awood0727 wants to merge 1 commit intoprocessing:mainfrom
Conversation
Signed-off-by: Amante' Woodley <awood0727@gmail.com> Co-authored-by: Nia Perez <nia.perez.506@gmail.com> Co-authored-by: Kayla Bobo <kay3583@gmail.com> Co-authored-by: Silas Morgan <victorsmorgan@gmail.com>
|
hi @awood0727 and crew, thank you for fixing this! I just have a quick question about the |
|
Hello @Stefterv, our thought process with the Debugger.pdeToSketchLine code was due to us creating a similar return line for the .pde files like was given for the .java files in LineBreakpoint.java we assumed that we needed to also create a similar function in Debugger. However if you believe that functions is not needed than we can take the code out if you would like us too. |
|
Yeah if the function is unused, which it seems to be, please remove it. Great work! |
|
Apologies for the delay but the fix should be implemented by the end of the week, my classes started a couple weeks ago so I'm trying to find a good time. |
|
Hey @awood0727 great thank you! Can you please close this PR then? |
|
Will do thanks again! |
Resolves
This PR resolves #1190
Changes
Tests
Screenshots
Before Implementation
After Implementation