Fixed SHIFT and PAGE_UP keys using the same keyCode#1033
Merged
Stefterv merged 4 commits intoprocessing:mainfrom Jul 11, 2025
Merged
Fixed SHIFT and PAGE_UP keys using the same keyCode#1033Stefterv merged 4 commits intoprocessing:mainfrom
SHIFT and PAGE_UP keys using the same keyCode#1033Stefterv merged 4 commits intoprocessing:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a patch for fixing the shift and page up sharing the same code. The problem is JOGL/NEWT doesn't guarantee the same keycode mappings as AWT. They have their own virtual key codes so I created a
normalizeKeyCodefunction to handle few differences in key codes.Also added a test for it.
Fixes #702