-
Notifications
You must be signed in to change notification settings - Fork 648
Remove PointerBox from @primer-react #6857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 0160b5c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the deprecated PointerBox component from the @primer/react package as part of the major release cleanup. The PointerBox was previously deprecated in v38.0.0 and is now being completely removed.
- Complete removal of PointerBox component including implementation, tests, stories, and documentation
- Updates to export files and test snapshots to reflect the component removal
- Documentation updates to remove references to PointerBox
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react/src/index.ts | Removes PointerBox exports from main package exports |
| packages/react/src/deprecated/index.ts | Removes PointerBox exports from deprecated exports |
| packages/react/src/tests/snapshots/exports.test.ts.snap | Updates test snapshots to reflect removed exports |
| packages/react/src/PointerBox/index.ts | Deletes the PointerBox index file |
| packages/react/src/PointerBox/PointerBox.tsx | Deletes the main PointerBox component implementation |
| packages/react/src/PointerBox/PointerBox.test.tsx | Deletes PointerBox unit tests |
| packages/react/src/PointerBox/PointerBox.stories.tsx | Deletes PointerBox Storybook stories |
| packages/react/src/PointerBox/PointerBox.docs.json | Deletes PointerBox documentation metadata |
| packages/react/script/react-compiler.mjs | Removes PointerBox from React compiler unsupported files list |
| contributor-docs/behaviors.md | Updates documentation to remove PointerBox reference |
Pull Request is not mergeable
Closes #https://github.com/github/primer/issues/5536
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist