-
Notifications
You must be signed in to change notification settings - Fork 650
Remove support for sx from CheckboxGroup component
#6655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 4eb192a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the sx prop support from the CheckboxGroup component as part of a design system migration strategy. The change eliminates the ability to pass custom styling through the sx prop, with teams expected to use @primer/styled-react as an alternative for custom styling needs.
Key changes:
- Removal of
SxProptype fromCheckboxGroupcomponent interface - Documentation updates removing
sxprop references from all subcomponents - Test story cleanup removing
sx-related test cases
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react/src/CheckboxGroup/CheckboxGroup.tsx | Removes SxProp import and type union, eliminating sx prop support from the main component |
| packages/react/src/CheckboxGroup/CheckboxGroup.docs.json | Updates component documentation by removing deprecated sx prop entries from main component and all subcomponents |
| e2e/components/CheckboxGroup.test.ts | Removes visual regression test for sx props functionality |
| .changeset/tame-ducks-ring.md | Adds major version changeset documenting the breaking change |
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/2772 |
|
🟢 ci completed with status |
Closes https://github.com/github/primer/issues/5760
Current
sxusage: 1❌ Still need to separately update github-ui components to use @primer/styled-react
github/github-ui PR: https://github.com/github/github-ui/pull/1676
Changelog
Removed
Remove support for
sxfrom theCheckboxGroupcomponent, and associated stories, docs, and testsRollout strategy
We are using the
@primer/styled-reactcomponent to mitigate removingsxusage. We will make sure usage is updated upstream before merging.Merge checklist