Skip to content

Conversation

@llastflowers
Copy link
Contributor

@llastflowers llastflowers commented Aug 22, 2025

Closes https://github.com/github/primer/issues/5760

Current sx usage: 1

❌ Still need to separately update github-ui components to use @primer/styled-react
github/github-ui PR: https://github.com/github/github-ui/pull/1676

Changelog

Removed

Remove support for sx from the CheckboxGroup component, and associated stories, docs, and tests

Rollout strategy

  • Major release; if selected, include a written rollout or migration plan

We are using the @primer/styled-react component to mitigate removing sx usage. We will make sure usage is updated upstream before merging.

Merge checklist

@llastflowers llastflowers self-assigned this Aug 22, 2025
@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2025

🦋 Changeset detected

Latest commit: 4eb192a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Aug 22, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 89.52 KB (0%)
packages/react/dist/browser.umd.js 89.62 KB (0%)

@github-actions github-actions bot requested a deployment to storybook-preview-6655 August 22, 2025 22:21 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6655 August 22, 2025 22:33 Inactive
@llastflowers llastflowers marked this pull request as ready for review September 5, 2025 15:39
Copilot AI review requested due to automatic review settings September 5, 2025 15:39
@llastflowers llastflowers requested a review from a team as a code owner September 5, 2025 15:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the sx prop support from the CheckboxGroup component as part of a design system migration strategy. The change eliminates the ability to pass custom styling through the sx prop, with teams expected to use @primer/styled-react as an alternative for custom styling needs.

Key changes:

  • Removal of SxProp type from CheckboxGroup component interface
  • Documentation updates removing sx prop references from all subcomponents
  • Test story cleanup removing sx-related test cases

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

File Description
packages/react/src/CheckboxGroup/CheckboxGroup.tsx Removes SxProp import and type union, eliminating sx prop support from the main component
packages/react/src/CheckboxGroup/CheckboxGroup.docs.json Updates component documentation by removing deprecated sx prop entries from main component and all subcomponents
e2e/components/CheckboxGroup.test.ts Removes visual regression test for sx props functionality
.changeset/tame-ducks-ring.md Adds major version changeset documenting the breaking change

@github-actions github-actions bot temporarily deployed to storybook-preview-6655 September 12, 2025 17:34 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Sep 12, 2025
@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/2772

@primer-integration
Copy link

🟢 ci completed with status success.

@github-actions github-actions bot removed the integration-tests: failing Changes in this PR cause breaking changes in gh/gh label Sep 17, 2025
@github-actions github-actions bot added the integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh label Sep 17, 2025
@llastflowers llastflowers added this pull request to the merge queue Sep 22, 2025
Merged via the queue into main with commit 092185f Sep 22, 2025
43 checks passed
@llastflowers llastflowers deleted the llastflowers/5760/no-sx-CheckboxGroup branch September 22, 2025 17:25
@primer primer bot mentioned this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants