Fixed bugs, reported in issue #8. #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bunch of memory leaks, occuring in tests. One heap-buffer-overrun in read operation at convert.c:3162. Two memory leaks, detected by my unit tests: password, conn_settings, pqopt fields overwrite if their values provided by both, system config and connstring. Restored reference counting lifetime managment of COL_INFO objects. Some minor cosmetic changes. Signed-off-by: Alexandr Kuznetsov <progmachine@xenlab.one>
Signed-off-by: Alexandr Kuznetsov <progmachine@xenlab.one>
Signed-off-by: Alexandr Kuznetsov <progmachine@xenlab.one>
davecramer
reviewed
May 23, 2024
connection.c
Outdated
|
|
||
| for (i = 0; i < self->ntables; i++) | ||
| { | ||
| {/* Going through COL_INFO cache table and releasing coli objects. */ |
Contributor
There was a problem hiding this comment.
Could you put comments on their own line. This is how the rest of the code is commented.
Signed-off-by: Alexandr Kuznetsov <progmachine@xenlab.one>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bunch of memory leaks, occuring in tests.
One heap-buffer-overrun in read operation at convert.c:3162.
Two memory leaks, detected by my unit tests:
password, conn_settings, pqopt fields overwrite if their values provided by both, system config and connstring.
Restored reference counting lifetime management of COL_INFO objects.
Some minor cosmetic changes.