Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/6217~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/6217
Choose a head ref
  • 5 commits
  • 16 files changed
  • 2 contributors

Commits on Dec 2, 2025

  1. Use radix sort when SortTuple contains a pass-by-value datum 

    For now this only works for signed and unsigned ints
with the usual comparison semantics, the same types
for which we previously had separate qsort
specializations.

Temporary GUC wip_radix_sort for testing

Reviewed-by: Chengpeng Yan <chengpeng_yan@outlook.com>
Reviewed-by: Álvaro Herrera <alvherre@kurilemu.de>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Tested-by: Chao Li <li.evan.chao@gmail.com> (earlier version)
    @j-naylor
    j-naylor authored and Commitfest Bot committed Dec 2, 2025
    Configuration menu
    Copy the full SHA
    df3013f View commit details
    Browse the repository at this point in the history

  2. WIP Adjust regression tests 

    Regression tests don't pass for underspecified queries; this
is expected since both qsort and in-place radix sort are
unstable sorts. For the query

SELECT a, b from mytable ORDER BY a;

...a stable sort would guarantee the relative position of 'b'
for each group of 'a', compared to the input.

This is separated out since the relative order changes with
the qsort threshold, same as it would for qsort and its
insertion sort threshold. Assert builds for now do radix
sort regardless of input size, if the data type allows it.

The final commit will have the same threshold for all builds.
    @j-naylor
    j-naylor authored and Commitfest Bot committed Dec 2, 2025
    Configuration menu
    Copy the full SHA
    497ea1b View commit details
    Browse the repository at this point in the history

  3. WIP make some regression tests' sort order more deterministic 

    The previous commit still results in failures in the TAP test
002_pg_upgrade.pl, namely that the regression tests fail on
the old cluster.

XXX it's not clear why only some tests fail this way
    @j-naylor
    j-naylor authored and Commitfest Bot committed Dec 2, 2025
    Configuration menu
    Copy the full SHA
    8094a7b View commit details
    Browse the repository at this point in the history

  4. Detect common prefix to avoid wasted work during radix sort 

    This is particularly useful for integers, since they commonly
have some zero upper bytes.
    @j-naylor
    j-naylor authored and Commitfest Bot committed Dec 2, 2025
    Configuration menu
    Copy the full SHA
    c9cdd84 View commit details
    Browse the repository at this point in the history

  5. [CF 6217] v5 - tuple radix sort 

    This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/6217

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/CANWCAZZiMGj6QuHfyBPv9at7xn23NPAz4nit=G6fr26V+h8MKg@mail.gmail.com
Author(s): John Naylor
    Commitfest Bot committed Dec 2, 2025
    Configuration menu
    Copy the full SHA
    27d4c58 View commit details
    Browse the repository at this point in the history
Loading