Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/6077~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/6077
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Oct 1, 2025

  1. Fix "unexpected zero page" in pgstattuple for hash and gist indexes 

    * pgstattuple calls check functions for all the pages in hash and
  gist indexes. These calls are made from pgstat_hash_page() and
  pgstat_gist_page(). For zero pages, these call lead to ERRCODE_INDEX_CORRUPTED.

* Since zero pages are normal after a crash, these errors are false alarms.
  pgstat_btree_page() avoids these errors by not running these checks.

* In this patch, we do the same for gist and hash indexes. For hash index,
  ReadBufferExtended() replaces _hash_getbuf_with_strategy() which was
  calling _hash_check_page(). Instead we do the required check for special
  size explicitly for the non-PageIsNew() cases.

* Similarly for gist index, we remove gistcheckpage() and explicitly
  checks the special size for the non-PageIsNew() cases before checking
  if the page is a leaf.

* The comments in the else clauses have been updated accordingly.

Reported-by: Noah Misch <noah@leadboat.com>
    Nitin Motiani authored and Commitfest Bot committed Oct 1, 2025
    Configuration menu
    Copy the full SHA
    d13eae0 View commit details
    Browse the repository at this point in the history

  2. [CF 6077] v3 - pgstattuple "unexpected zero page" for gist and hash i… 

    …ndexes

This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/6077

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/CAH5HC977v7n9qKZ5nGLjk4a9CXosG5mktbMTmxi6Z_qu4uYy4g@mail.gmail.com
Author(s): Nitin Motiani
    Commitfest Bot committed Oct 1, 2025
    Configuration menu
    Copy the full SHA
    f118f47 View commit details
    Browse the repository at this point in the history
Loading