Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/5820~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/5820
Choose a head ref
  • 3 commits
  • 12 files changed
  • 2 contributors

Commits on Jul 28, 2025

  1. Avoid putting library-supplied -L switches before user-supplied ones. 

    For many optional libraries, we extract the -L and -l switches needed
to link the library from a helper program such as llvm-config.  In
some cases we put the resulting -L switches into LDFLAGS ahead of
-L switches specified via --with-libraries.  That risks breaking
the user's intention for --with-libraries.

It's not such a problem if the library's -L switch points to a
directory containing only that library, but on some platforms a
library helper may "helpfully" offer a switch such as -L/usr/lib
that points to a directory holding all standard libraries.  If the
user specified --with-libraries in hopes of overriding the standard
build of some library, the -L/usr/lib switch prevents that from
happening since it will come before the user-specified directory.

To fix, avoid inserting these switches directly into LDFLAGS during
configure, instead adding them to LIBDIRS or SHLIB_LINK.  They will
still eventually get added to LDFLAGS, but only after the switches
coming from --with-libraries.

The Meson build scripts may or may not have any comparable problem,
but I'll leave it to someone else to investigate that.

Reported-by: Charles Samborski <demurgos@demurgos.net>
Author: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/70f2155f-27ca-4534-b33d-7750e20633d7@demurgos.net
    @tglsfdc
    tglsfdc authored and Commitfest Bot committed Jul 28, 2025
    Configuration menu
    Copy the full SHA
    c912358 View commit details
    Browse the repository at this point in the history

  2. Avoid putting library-supplied -I switches before user-supplied ones. 

    This patch fixes the same problem as the previous one, but with
respect to -I switches: those coming from --with-includes should
appear before any coming from outside sources such as llvm-config.
We have not heard field complaints about this case, but it seems
certain that a user attempting to override a standard library
could have issues.

The changes for this go well beyond configure itself, however,
because many Makefiles have occasion to manipulate CPPFLAGS to
insert locally-desirable -I switches, and some of them got it wrong.
The correct ordering is any -I switches pointing at within-the-
source-tree-or-build-tree directories, then those from the tree-wide
CPPFLAGS, then those from outside sources such as llvm-config.
There were several places that risked pulling in a system-supplied
copy of libpq headers, for example, instead of the in-tree files.

The Meson build scripts may or may not have any comparable problem,
but I'll leave it to someone else to investigate that.

Reported-by: Charles Samborski <demurgos@demurgos.net>
Author: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/70f2155f-27ca-4534-b33d-7750e20633d7@demurgos.net
    @tglsfdc
    tglsfdc authored and Commitfest Bot committed Jul 28, 2025
    Configuration menu
    Copy the full SHA
    baf8f9b View commit details
    Browse the repository at this point in the history

  3. [CF 5820] v2 - Avoid overriding user's --with-libs settings 

    This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/5820

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/287407.1753655398@sss.pgh.pa.us
Author(s): Tom Lane
    Commitfest Bot committed Jul 28, 2025
    Configuration menu
    Copy the full SHA
    52cc46a View commit details
    Browse the repository at this point in the history
Loading