Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/5708~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/5708
Choose a head ref
  • 4 commits
  • 9 files changed
  • 2 contributors

Commits on May 1, 2025

  1. Don't generate fake *SELECT* or *SELECT %d* subquery aliases. 

    rte->alias should point only to a user-written alias, but in these
case that principle was violated. Fixing this causes some regression
test output changes: wherever rte->alias previously had a value and is
now NULL, rte->eref is now set to a generated name rather than to
rte->alias; and the scheme used to eref names differs from what we
were doing for aliases.

Author: Tom Lane <tgl@sss.pgh.pa.us>
Co-authored-by: Robert Haas <rhaas@postgresql.org>
    @robertmhaas
    robertmhaas authored and Commitfest Bot committed May 1, 2025
    Configuration menu
    Copy the full SHA
    66ae446 View commit details
    Browse the repository at this point in the history

  2. Don't generate fake ANY_subquery aliases, either. 

    This is just like the previos commit, but for a different invented
alias name.

Author: Robert Haas <rhaas@postgresql.org>
    @robertmhaas
    robertmhaas authored and Commitfest Bot committed May 1, 2025
    Configuration menu
    Copy the full SHA
    198f4e7 View commit details
    Browse the repository at this point in the history

  3. Don't generate fake *TLOCRN* or *TROCRN* aliases, either. 

    This fix actually doesn't change any regression test outputs.

Author: Robert Haas <rhaas@postgresql.org>
    @robertmhaas
    robertmhaas authored and Commitfest Bot committed May 1, 2025
    Configuration menu
    Copy the full SHA
    9449439 View commit details
    Browse the repository at this point in the history

  4. [CF 5708] v2 - don't generate fake alias names, only fake eref names 

    This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/5708

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/CA+TgmoYt1eKQvER4eua3KAkLNPpjQdBM=iTy7OtSKNWtn=eVbQ@mail.gmail.com
Author(s): Robert Haas
    Commitfest Bot committed May 1, 2025
    Configuration menu
    Copy the full SHA
    a44f687 View commit details
    Browse the repository at this point in the history
Loading