Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/4720~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/4720
Choose a head ref
  • 2 commits
  • 8 files changed
  • 2 contributors

Commits on Jun 21, 2025

  1. Ignore temporary relations in RelidByRelfilenumber() 

    Temporary relations may have the same relfilenumber as a permanent
relation, or other temporary relations associated with other sessions.
The function may get confused if the given relfilenumber and tablespace
is associated with one or more temporary tables and throw an error. This
will disturb the intended users of this function i.e. logical
replication and autoprewarm, which lookup only permanent relation. Hence
the function only considers only non-temporary relations.  The third
caller of this function is pg_filenode_relation(). It throws an error in
such cases. We require proc number of the backend which created the
temporary table along with the tablespace and relfilenumber in order to
uniquely identify a temporary relation. Since any user visible backend
identifier is not an argument to this function, it is doubtful whether
the function was intended to be used to map temporary relations. In
short, considering temporary relations seems to be an oversight in
commit f01d1ae. Fix it.

Author: Vignesh C <vignesh21@gmail.com>
Reported-By: Shenhao Wang <wangsh.fnst@fujitsu.com>
Reviewed-By: Michael Paquier <michael@paquier.xyz>,
Reviewed-By: Robert Haas <robertmhaas@gmail.com>,
Reviewed-By: Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
Reviewed-By: Takamichi Osumi <osumi.takamichi@fujitsu.com>
Reviewed-By: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/bbaaf9f9-ebb2-645f-54bb-34d6efc7ac42%40fujitsu.com
    @ashutosh-bapat
    ashutosh-bapat authored and Commitfest Bot committed Jun 21, 2025
    Configuration menu
    Copy the full SHA
    c03ebd9 View commit details
    Browse the repository at this point in the history

  2. [CF 4720] "unexpected duplicate for tablespace" problem in logical re… 

    …plication

This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/4720

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/CAExHW5vaHu=s6eopJ2jxyGNRG--uEsJwYk92yxa2L_80+Y=1YA@mail.gmail.com
Author(s): Shenhao Wang
    Commitfest Bot committed Jun 21, 2025
    Configuration menu
    Copy the full SHA
    16799fc View commit details
    Browse the repository at this point in the history
Loading