Fix add_vline text annotation with dates#3731
Open
jjrob13 wants to merge 2 commits intoplotly:mainfrom
Open
Conversation
Author
|
cc: @nicolaskruchten this is a small bugfix that is useful for us, and it looks like people have been reporting it a few times (see PR description for issue) |
Contributor
|
@marthacryan can you please have a look at this one (and if possible add a test when merging) thanks - @gvwilson |
|
As this comment (#3065 (comment)) mentions, I would suggest checking for types would be a better way than making workaround fixes to those methods. |
amiteitan
approved these changes
May 20, 2025
amiteitan
left a comment
There was a problem hiding this comment.
This is just a simple typo fix and it looks good enogh
amiteitan
added a commit
to amiteitan/plotly.py
that referenced
this pull request
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
I would like to use add_vline with a text annotation.
Closes: #3065
The workaround presented in #3065 (comment) breaks if people view the plot in a difference timezone than where it was generated.
As mentioned in that ticket, here is the error when data is used for text annotations
TypeError: unsupported operand type(s) for +: 'int' and 'str'The backtrace looks like:
For line annotations, the same x value is passed for both x1/x2, so the mean is trivial to compute.
Code PR
plotly.graph_objects, my modifications concern thecodegenfiles and not generated files.modified existing tests.
new tutorial notebook (please see the doc checklist as well).
Test Plan
I'm now able to use add_vline and text annotations with dates. The repro in #3065 works now