ftp error tests #3273
Closed
ftp error tests #3273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
carusogabriel
left a comment
carusogabriel
left a comment
There was a problem hiding this comment.
Can you please provide the GCov link pointing these tests are need?
Contributor
Author
Member
|
@chancegarcia Could you please address the test failures? There is at least something wrong with ftp_pwd_error.phpt. |
Member
|
Also, please combine all the "not a valid FTP Buffer resource" tests into one file to reduce the runtime impact of these tests. |
Member
|
We are not accepting test fest pull requests directly, please make the pull request here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phptek 2018 testfest