From e8bc1514c1ee218729ea0a7426dfe53ee94b5f45 Mon Sep 17 00:00:00 2001
From: chance garcia <develop@chancegarcia.com>
Date: Mon, 4 Jun 2018 23:33:20 -0400
Subject: [PATCH 1/2] test ftp resource is passed into ftp functions

---
 ext/ftp/tests/ftp_alloc_error.phpt       | 14 ++++++++++++++
 ext/ftp/tests/ftp_append_error.phpt      | 15 +++++++++++++++
 ext/ftp/tests/ftp_cdup_error.phpt        | 14 ++++++++++++++
 ext/ftp/tests/ftp_chdir_error.phpt       | 14 ++++++++++++++
 ext/ftp/tests/ftp_chmod_error.phpt       | 14 ++++++++++++++
 ext/ftp/tests/ftp_close_error.phpt       | 14 ++++++++++++++
 ext/ftp/tests/ftp_delete_error.phpt      | 15 +++++++++++++++
 ext/ftp/tests/ftp_exec_error.phpt        | 14 ++++++++++++++
 ext/ftp/tests/ftp_fget_error.phpt        | 15 +++++++++++++++
 ext/ftp/tests/ftp_fput_error.phpt        | 16 ++++++++++++++++
 ext/ftp/tests/ftp_get_error.phpt         | 16 ++++++++++++++++
 ext/ftp/tests/ftp_get_option_error.phpt  | 14 ++++++++++++++
 ext/ftp/tests/ftp_login_error.phpt       | 14 ++++++++++++++
 ext/ftp/tests/ftp_mdtm_error.phpt        | 15 +++++++++++++++
 ext/ftp/tests/ftp_mkdir_error.phpt       | 14 ++++++++++++++
 ext/ftp/tests/ftp_mlsd_error.phpt        | 14 ++++++++++++++
 ext/ftp/tests/ftp_nb_continue_error.phpt | 14 ++++++++++++++
 ext/ftp/tests/ftp_nb_fget_error.phpt     | 15 +++++++++++++++
 ext/ftp/tests/ftp_nb_fput_error.phpt     | 16 ++++++++++++++++
 ext/ftp/tests/ftp_nb_get_error.phpt      | 15 +++++++++++++++
 ext/ftp/tests/ftp_nb_put_error.phpt      | 15 +++++++++++++++
 ext/ftp/tests/ftp_nlist_error.phpt       | 14 ++++++++++++++
 ext/ftp/tests/ftp_pasv_error.phpt        | 14 ++++++++++++++
 ext/ftp/tests/ftp_put_error.phpt         | 15 +++++++++++++++
 ext/ftp/tests/ftp_pwd_error.phpt         | 14 ++++++++++++++
 ext/ftp/tests/ftp_raw_error.phpt         | 14 ++++++++++++++
 ext/ftp/tests/ftp_rawlist_error.phpt     | 14 ++++++++++++++
 ext/ftp/tests/ftp_rename_error.phpt      | 14 ++++++++++++++
 ext/ftp/tests/ftp_rmdir_error.phpt       | 14 ++++++++++++++
 ext/ftp/tests/ftp_set_option_error.phpt  | 14 ++++++++++++++
 ext/ftp/tests/ftp_site_error.phpt        | 14 ++++++++++++++
 ext/ftp/tests/ftp_size_error.phpt        | 15 +++++++++++++++
 ext/ftp/tests/ftp_ssl_connect_error.phpt |  5 ++++-
 ext/ftp/tests/ftp_systype_error.phpt     | 14 ++++++++++++++
 34 files changed, 481 insertions(+), 1 deletion(-)
 create mode 100644 ext/ftp/tests/ftp_alloc_error.phpt
 create mode 100644 ext/ftp/tests/ftp_append_error.phpt
 create mode 100644 ext/ftp/tests/ftp_cdup_error.phpt
 create mode 100644 ext/ftp/tests/ftp_chdir_error.phpt
 create mode 100644 ext/ftp/tests/ftp_chmod_error.phpt
 create mode 100644 ext/ftp/tests/ftp_close_error.phpt
 create mode 100644 ext/ftp/tests/ftp_delete_error.phpt
 create mode 100644 ext/ftp/tests/ftp_exec_error.phpt
 create mode 100644 ext/ftp/tests/ftp_fget_error.phpt
 create mode 100644 ext/ftp/tests/ftp_fput_error.phpt
 create mode 100644 ext/ftp/tests/ftp_get_error.phpt
 create mode 100644 ext/ftp/tests/ftp_get_option_error.phpt
 create mode 100644 ext/ftp/tests/ftp_login_error.phpt
 create mode 100644 ext/ftp/tests/ftp_mdtm_error.phpt
 create mode 100644 ext/ftp/tests/ftp_mkdir_error.phpt
 create mode 100644 ext/ftp/tests/ftp_mlsd_error.phpt
 create mode 100644 ext/ftp/tests/ftp_nb_continue_error.phpt
 create mode 100644 ext/ftp/tests/ftp_nb_fget_error.phpt
 create mode 100644 ext/ftp/tests/ftp_nb_fput_error.phpt
 create mode 100644 ext/ftp/tests/ftp_nb_get_error.phpt
 create mode 100644 ext/ftp/tests/ftp_nb_put_error.phpt
 create mode 100644 ext/ftp/tests/ftp_nlist_error.phpt
 create mode 100644 ext/ftp/tests/ftp_pasv_error.phpt
 create mode 100644 ext/ftp/tests/ftp_put_error.phpt
 create mode 100644 ext/ftp/tests/ftp_pwd_error.phpt
 create mode 100644 ext/ftp/tests/ftp_raw_error.phpt
 create mode 100644 ext/ftp/tests/ftp_rawlist_error.phpt
 create mode 100644 ext/ftp/tests/ftp_rename_error.phpt
 create mode 100644 ext/ftp/tests/ftp_rmdir_error.phpt
 create mode 100644 ext/ftp/tests/ftp_set_option_error.phpt
 create mode 100644 ext/ftp/tests/ftp_site_error.phpt
 create mode 100644 ext/ftp/tests/ftp_size_error.phpt
 create mode 100644 ext/ftp/tests/ftp_systype_error.phpt

diff --git a/ext/ftp/tests/ftp_alloc_error.phpt b/ext/ftp/tests/ftp_alloc_error.phpt
new file mode 100644
index 0000000000000..947e12b68a795
--- /dev/null
+++ b/ext/ftp/tests/ftp_alloc_error.phpt
@@ -0,0 +1,14 @@
+--TEST--
+Testing ftp_alloc error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+ftp_alloc($notFtp, 1, $result);
+
+?>
+--EXPECTF--
+Warning: ftp_alloc(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_append_error.phpt b/ext/ftp/tests/ftp_append_error.phpt
new file mode 100644
index 0000000000000..91bf2f5a59489
--- /dev/null
+++ b/ext/ftp/tests/ftp_append_error.phpt
@@ -0,0 +1,15 @@
+--TEST--
+Testing ftp_append error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+$destination_file = basename(__FILE__);
+ftp_append($notFtp, $destination_file, 'a storty.txt', FTP_ASCII);
+
+?>
+--EXPECTF--
+Warning: ftp_append(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_cdup_error.phpt b/ext/ftp/tests/ftp_cdup_error.phpt
new file mode 100644
index 0000000000000..bc4b78fe726b1
--- /dev/null
+++ b/ext/ftp/tests/ftp_cdup_error.phpt
@@ -0,0 +1,14 @@
+--TEST--
+Testing ftp_cdup error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+ftp_cdup($notFtp);
+
+?>
+--EXPECTF--
+Warning: ftp_cdup(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_chdir_error.phpt b/ext/ftp/tests/ftp_chdir_error.phpt
new file mode 100644
index 0000000000000..cda619d507147
--- /dev/null
+++ b/ext/ftp/tests/ftp_chdir_error.phpt
@@ -0,0 +1,14 @@
+--TEST--
+Testing ftp_chdir error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+ftp_chdir($notFtp, '/path/to/some/dir');
+
+?>
+--EXPECTF--
+Warning: ftp_chdir(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_chmod_error.phpt b/ext/ftp/tests/ftp_chmod_error.phpt
new file mode 100644
index 0000000000000..a1dc11d256cf1
--- /dev/null
+++ b/ext/ftp/tests/ftp_chmod_error.phpt
@@ -0,0 +1,14 @@
+--TEST--
+Testing ftp_chmod error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+ftp_chmod($notFtp, 0000, '/path/to/some/dir');
+
+?>
+--EXPECTF--
+Warning: ftp_chmod(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_close_error.phpt b/ext/ftp/tests/ftp_close_error.phpt
new file mode 100644
index 0000000000000..7db0f5783247e
--- /dev/null
+++ b/ext/ftp/tests/ftp_close_error.phpt
@@ -0,0 +1,14 @@
+--TEST--
+Testing ftp_close error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+ftp_close($notFtp);
+
+?>
+--EXPECTF--
+Warning: ftp_close(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_delete_error.phpt b/ext/ftp/tests/ftp_delete_error.phpt
new file mode 100644
index 0000000000000..982eb8277b82d
--- /dev/null
+++ b/ext/ftp/tests/ftp_delete_error.phpt
@@ -0,0 +1,15 @@
+--TEST--
+Testing ftp_delete error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+$destination_file = basename(__FILE__);
+ftp_delete($notFtp, $destination_file);
+
+?>
+--EXPECTF--
+Warning: ftp_delete(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_exec_error.phpt b/ext/ftp/tests/ftp_exec_error.phpt
new file mode 100644
index 0000000000000..76657d781c27e
--- /dev/null
+++ b/ext/ftp/tests/ftp_exec_error.phpt
@@ -0,0 +1,14 @@
+--TEST--
+Testing ftp_exec error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+ftp_exec($notFtp, 'ls -hal');
+
+?>
+--EXPECTF--
+Warning: ftp_exec(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_fget_error.phpt b/ext/ftp/tests/ftp_fget_error.phpt
new file mode 100644
index 0000000000000..0f9a9f87f6d2f
--- /dev/null
+++ b/ext/ftp/tests/ftp_fget_error.phpt
@@ -0,0 +1,15 @@
+--TEST--
+Testing ftp_fget error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+$fp = tmpfile();
+ftp_fget($notFtp, $fp, 'a story.txt', FTP_ASCII);
+
+?>
+--EXPECTF--
+Warning: ftp_fget(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_fput_error.phpt b/ext/ftp/tests/ftp_fput_error.phpt
new file mode 100644
index 0000000000000..0ce2d3a719c86
--- /dev/null
+++ b/ext/ftp/tests/ftp_fput_error.phpt
@@ -0,0 +1,16 @@
+--TEST--
+Testing ftp_fput error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+$destination_file = basename(__FILE__);
+$source_file = fopen(__FILE__, 'r');
+ftp_fput($notFtp, $destination_file, $source_file, FTP_ASCII);
+
+?>
+--EXPECTF--
+Warning: ftp_fput(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_get_error.phpt b/ext/ftp/tests/ftp_get_error.phpt
new file mode 100644
index 0000000000000..b28584855a011
--- /dev/null
+++ b/ext/ftp/tests/ftp_get_error.phpt
@@ -0,0 +1,16 @@
+--TEST--
+Testing ftp_get error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+$tmpfname = tempnam(__DIR__, "ftp_test");
+ftp_get($notFtp, $tmpfname, 'a story.txt', FTP_ASCII);
+unlink($tmpfname);
+
+?>
+--EXPECTF--
+Warning: ftp_get(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_get_option_error.phpt b/ext/ftp/tests/ftp_get_option_error.phpt
new file mode 100644
index 0000000000000..7ea8436535652
--- /dev/null
+++ b/ext/ftp/tests/ftp_get_option_error.phpt
@@ -0,0 +1,14 @@
+--TEST--
+Testing ftp_get_option error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+ftp_get_option($notFtp, FTP_TIMEOUT_SEC);
+
+?>
+--EXPECTF--
+Warning: ftp_get_option(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_login_error.phpt b/ext/ftp/tests/ftp_login_error.phpt
new file mode 100644
index 0000000000000..3c9446dc6cb93
--- /dev/null
+++ b/ext/ftp/tests/ftp_login_error.phpt
@@ -0,0 +1,14 @@
+--TEST--
+Testing ftp_login error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+ftp_login($notFtp, 'user', 'pass');
+
+?>
+--EXPECTF--
+Warning: ftp_login(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_mdtm_error.phpt b/ext/ftp/tests/ftp_mdtm_error.phpt
new file mode 100644
index 0000000000000..dfd6d1029ede4
--- /dev/null
+++ b/ext/ftp/tests/ftp_mdtm_error.phpt
@@ -0,0 +1,15 @@
+--TEST--
+Testing ftp_mdtm error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+$destination_file = basename(__FILE__);
+ftp_mdtm($notFtp, $destination_file);
+
+?>
+--EXPECTF--
+Warning: ftp_mdtm(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_mkdir_error.phpt b/ext/ftp/tests/ftp_mkdir_error.phpt
new file mode 100644
index 0000000000000..573d8e46f197a
--- /dev/null
+++ b/ext/ftp/tests/ftp_mkdir_error.phpt
@@ -0,0 +1,14 @@
+--TEST--
+Testing ftp_mkdir error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+ftp_mkdir($notFtp, '/path/to/some/dir');
+
+?>
+--EXPECTF--
+Warning: ftp_mkdir(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_mlsd_error.phpt b/ext/ftp/tests/ftp_mlsd_error.phpt
new file mode 100644
index 0000000000000..5b6944e4af241
--- /dev/null
+++ b/ext/ftp/tests/ftp_mlsd_error.phpt
@@ -0,0 +1,14 @@
+--TEST--
+Testing ftp_mlsd error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+ftp_mlsd($notFtp, '/path/to/some/dir');
+
+?>
+--EXPECTF--
+Warning: ftp_mlsd(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_nb_continue_error.phpt b/ext/ftp/tests/ftp_nb_continue_error.phpt
new file mode 100644
index 0000000000000..6cdebc0e3192d
--- /dev/null
+++ b/ext/ftp/tests/ftp_nb_continue_error.phpt
@@ -0,0 +1,14 @@
+--TEST--
+Testing ftp_nb_continue error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+ftp_nb_continue($notFtp);
+
+?>
+--EXPECTF--
+Warning: ftp_nb_continue(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_nb_fget_error.phpt b/ext/ftp/tests/ftp_nb_fget_error.phpt
new file mode 100644
index 0000000000000..a928b934dac0f
--- /dev/null
+++ b/ext/ftp/tests/ftp_nb_fget_error.phpt
@@ -0,0 +1,15 @@
+--TEST--
+Testing ftp_nb_fget error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+$fp = tmpfile();
+ftp_nb_fget($notFtp, $fp, 'a story.txt', FTP_ASCII);
+
+?>
+--EXPECTF--
+Warning: ftp_nb_fget(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_nb_fput_error.phpt b/ext/ftp/tests/ftp_nb_fput_error.phpt
new file mode 100644
index 0000000000000..2e8a630832cea
--- /dev/null
+++ b/ext/ftp/tests/ftp_nb_fput_error.phpt
@@ -0,0 +1,16 @@
+--TEST--
+Testing ftp_nb_fput error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+$destination_file = basename(__FILE__);
+$source_file = fopen(__FILE__, 'r');
+ftp_nb_fput($notFtp, $destination_file, $source_file, FTP_ASCII);
+
+?>
+--EXPECTF--
+Warning: ftp_nb_fput(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_nb_get_error.phpt b/ext/ftp/tests/ftp_nb_get_error.phpt
new file mode 100644
index 0000000000000..388c8df5bd712
--- /dev/null
+++ b/ext/ftp/tests/ftp_nb_get_error.phpt
@@ -0,0 +1,15 @@
+--TEST--
+Testing ftp_nb_get error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+$tmpfname = tempnam(__DIR__, "ftp_test");
+ftp_nb_get($notFtp, $tmpfname, 'a story.txt', FTP_ASCII);
+unlink($tmpfname);
+?>
+--EXPECTF--
+Warning: ftp_nb_get(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_nb_put_error.phpt b/ext/ftp/tests/ftp_nb_put_error.phpt
new file mode 100644
index 0000000000000..6ea949be31d69
--- /dev/null
+++ b/ext/ftp/tests/ftp_nb_put_error.phpt
@@ -0,0 +1,15 @@
+--TEST--
+Testing ftp_nb_put error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+$destination_file = basename(__FILE__);
+ftp_nb_put($notFtp, $destination_file, 'a storty.txt', FTP_ASCII);
+
+?>
+--EXPECTF--
+Warning: ftp_nb_put(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_nlist_error.phpt b/ext/ftp/tests/ftp_nlist_error.phpt
new file mode 100644
index 0000000000000..361fa8cdf45b5
--- /dev/null
+++ b/ext/ftp/tests/ftp_nlist_error.phpt
@@ -0,0 +1,14 @@
+--TEST--
+Testing ftp_nlist error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+ftp_nlist($notFtp, '/path/to/some/dir');
+
+?>
+--EXPECTF--
+Warning: ftp_nlist(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_pasv_error.phpt b/ext/ftp/tests/ftp_pasv_error.phpt
new file mode 100644
index 0000000000000..0da630de89500
--- /dev/null
+++ b/ext/ftp/tests/ftp_pasv_error.phpt
@@ -0,0 +1,14 @@
+--TEST--
+Testing ftp_pasv error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+ftp_pasv($notFtp, true);
+
+?>
+--EXPECTF--
+Warning: ftp_pasv(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_put_error.phpt b/ext/ftp/tests/ftp_put_error.phpt
new file mode 100644
index 0000000000000..64dfc7cd38b3d
--- /dev/null
+++ b/ext/ftp/tests/ftp_put_error.phpt
@@ -0,0 +1,15 @@
+--TEST--
+Testing ftp_put error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+$destination_file = basename(__FILE__);
+ftp_put($notFtp, $destination_file, 'a storty.txt', FTP_ASCII);
+
+?>
+--EXPECTF--
+Warning: ftp_put(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_pwd_error.phpt b/ext/ftp/tests/ftp_pwd_error.phpt
new file mode 100644
index 0000000000000..a4cc7aab38dcc
--- /dev/null
+++ b/ext/ftp/tests/ftp_pwd_error.phpt
@@ -0,0 +1,14 @@
+--TEST--
+Testing ftp_pwd error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+ftp_login($notFtp);
+
+?>
+--EXPECTF--
+Warning: ftp_pwd(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_raw_error.phpt b/ext/ftp/tests/ftp_raw_error.phpt
new file mode 100644
index 0000000000000..69c79fd8ffccc
--- /dev/null
+++ b/ext/ftp/tests/ftp_raw_error.phpt
@@ -0,0 +1,14 @@
+--TEST--
+Testing ftp_raw error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+ftp_raw($notFtp, 'ls -hal');
+
+?>
+--EXPECTF--
+Warning: ftp_raw(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_rawlist_error.phpt b/ext/ftp/tests/ftp_rawlist_error.phpt
new file mode 100644
index 0000000000000..8468d1a974725
--- /dev/null
+++ b/ext/ftp/tests/ftp_rawlist_error.phpt
@@ -0,0 +1,14 @@
+--TEST--
+Testing ftp_rawlist error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+ftp_rawlist($notFtp, '/path/to/some/dir');
+
+?>
+--EXPECTF--
+Warning: ftp_rawlist(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_rename_error.phpt b/ext/ftp/tests/ftp_rename_error.phpt
new file mode 100644
index 0000000000000..ce790dc6d67cc
--- /dev/null
+++ b/ext/ftp/tests/ftp_rename_error.phpt
@@ -0,0 +1,14 @@
+--TEST--
+Testing ftp_rename error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+ftp_rename($notFtp, 'some_file.txt.bak', 'some_file.txt');
+
+?>
+--EXPECTF--
+Warning: ftp_rename(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_rmdir_error.phpt b/ext/ftp/tests/ftp_rmdir_error.phpt
new file mode 100644
index 0000000000000..ab18764897871
--- /dev/null
+++ b/ext/ftp/tests/ftp_rmdir_error.phpt
@@ -0,0 +1,14 @@
+--TEST--
+Testing ftp_rmdir error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+ftp_rmdir($notFtp, '/path/to/some/dir');
+
+?>
+--EXPECTF--
+Warning: ftp_rmdir(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_set_option_error.phpt b/ext/ftp/tests/ftp_set_option_error.phpt
new file mode 100644
index 0000000000000..530f78ec3e826
--- /dev/null
+++ b/ext/ftp/tests/ftp_set_option_error.phpt
@@ -0,0 +1,14 @@
+--TEST--
+Testing ftp_set_option error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+ftp_set_option($notFtp, FTP_TIMEOUT_SEC, 120);
+
+?>
+--EXPECTF--
+Warning: ftp_set_option(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_site_error.phpt b/ext/ftp/tests/ftp_site_error.phpt
new file mode 100644
index 0000000000000..3a519c06e3e38
--- /dev/null
+++ b/ext/ftp/tests/ftp_site_error.phpt
@@ -0,0 +1,14 @@
+--TEST--
+Testing ftp_site error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+ftp_site($notFtp, 'CHMOD 0600 /home/user/privatefile');
+
+?>
+--EXPECTF--
+Warning: ftp_site(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_size_error.phpt b/ext/ftp/tests/ftp_size_error.phpt
new file mode 100644
index 0000000000000..fdcbdfde32e94
--- /dev/null
+++ b/ext/ftp/tests/ftp_size_error.phpt
@@ -0,0 +1,15 @@
+--TEST--
+Testing ftp_size error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+$destination_file = basename(__FILE__);
+ftp_size($notFtp, $destination_file);
+
+?>
+--EXPECTF--
+Warning: ftp_size(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file
diff --git a/ext/ftp/tests/ftp_ssl_connect_error.phpt b/ext/ftp/tests/ftp_ssl_connect_error.phpt
index f139696c7f219..13e7fdad3a488 100644
--- a/ext/ftp/tests/ftp_ssl_connect_error.phpt
+++ b/ext/ftp/tests/ftp_ssl_connect_error.phpt
@@ -1,5 +1,8 @@
 --TEST--
 Test ftp_ssl_connect() function : error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2017-06-17
 --SKIPIF--
 <?php
 $ssl = 1;
@@ -24,7 +27,7 @@ echo "\n-- Testing ftp_ssl_connect() function timeout warning for value 0 --\n";
 ftp_ssl_connect('totes.invalid', 21, 0);
 
 echo "===DONE===\n";
-
+?>
 --EXPECTF--
 *** Testing ftp_ssl_connect() function : error conditions ***
 
diff --git a/ext/ftp/tests/ftp_systype_error.phpt b/ext/ftp/tests/ftp_systype_error.phpt
new file mode 100644
index 0000000000000..e41f2f7c5560b
--- /dev/null
+++ b/ext/ftp/tests/ftp_systype_error.phpt
@@ -0,0 +1,14 @@
+--TEST--
+Testing ftp_systype error conditions
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+$notFtp = fopen('php://stdin', 'r+');
+ftp_systype($notFtp);
+
+?>
+--EXPECTF--
+Warning: ftp_systype(): supplied resource is not a valid FTP Buffer resource in %s on line %d
\ No newline at end of file

From a2798896480cb23eeed8bf9cf4604420d9176430 Mon Sep 17 00:00:00 2001
From: chance garcia <develop@chancegarcia.com>
Date: Mon, 4 Jun 2018 23:34:07 -0400
Subject: [PATCH 2/2] test ftp rawlist empty directory

---
 ext/ftp/tests/ftp_rawlist_empty.phpt | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 ext/ftp/tests/ftp_rawlist_empty.phpt

diff --git a/ext/ftp/tests/ftp_rawlist_empty.phpt b/ext/ftp/tests/ftp_rawlist_empty.phpt
new file mode 100644
index 0000000000000..69d680940cc3a
--- /dev/null
+++ b/ext/ftp/tests/ftp_rawlist_empty.phpt
@@ -0,0 +1,27 @@
+--TEST--
+Testing ftp_rawlist empty directory
+--CREDITS--
+Chance Garcia <chance [at] chancegarcia [dot] com>
+#testfest php[tek] 2018-06-01
+--FILE--
+<?php
+
+require 'server.inc';
+
+$ftp = ftp_connect('127.0.0.1', $port);
+if (!$ftp) die("Couldn't connect to the server");
+
+var_dump(ftp_login($ftp, 'user', 'pass'));
+
+var_dump(ftp_rawlist($ftp, ''));
+var_dump(ftp_rawlist($ftp, 'emptydir'));
+
+ftp_close($ftp);
+
+?>
+--EXPECT--
+bool(true)
+string(6) "LIST
+"
+bool(false)
+bool(false)
\ No newline at end of file