-
Notifications
You must be signed in to change notification settings - Fork 838
Mark xml_parser_free as deprecated. #4892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Yes. It also needs to be marked deprecated in doc-en/reference/xml/versions.xml Line 16 in 84f2560
see: doc-en/reference/random/versions.xml Line 5 in 84f2560
The Attribute should also be added, but my understanding is this can be done in bulk based on the stubs:
|
|
Ah and changelog needs to be added: doc-en/reference/random/functions/lcg-value.xml Lines 56 to 76 in 84f2560
|
|
Done and done. |
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
* Mark xml_parser_free as deprecated. * Flesh out deprecation markers further. * Add formal warning. * Remove redundant text. Co-authored-by: Tim Düsterhus <timwolla@googlemail.com> --------- Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
Not sure if anything else is really needed here.