Skip to content

Conversation

@Crell
Copy link
Contributor

@Crell Crell commented Oct 3, 2025

Not sure if anything else is really needed here.

@TimWolla
Copy link
Member

TimWolla commented Oct 3, 2025

Not sure if anything else is really needed here.

Yes. It also needs to be marked deprecated in

<function name="xml_parser_free" from="PHP 4, PHP 5, PHP 7, PHP 8"/>
.

see:

<function name="lcg_value" from="PHP 4, PHP 5, PHP 7, PHP 8" deprecated="PHP 8.4.0"/>

The Attribute should also be added, but my understanding is this can be done in bulk based on the stubs:

<modifier role="attribute">#[\Deprecated]</modifier>

@TimWolla
Copy link
Member

TimWolla commented Oct 3, 2025

Ah and changelog needs to be added:

<refsect1 role="changelog">
&reftitle.changelog;
<informaltable>
<tgroup cols="2">
<thead>
<row>
<entry>&Version;</entry>
<entry>&Description;</entry>
</row>
</thead>
<tbody>
<row>
<entry>8.4.0</entry>
<entry>
This function has been deprecated.
</entry>
</row>
</tbody>
</tgroup>
</informaltable>
</refsect1>

@Crell
Copy link
Contributor Author

Crell commented Oct 3, 2025

Done and done.

Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
@Crell Crell merged commit 00a8ae0 into php:master Oct 4, 2025
2 checks passed
@Crell Crell deleted the xml_parser_free branch October 4, 2025 15:41
Crell added a commit to Crell/doc-en that referenced this pull request Dec 15, 2025
* Mark xml_parser_free as deprecated.

* Flesh out deprecation markers further.

* Add formal warning.

* Remove redundant text.

Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>

---------

Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants