Skip to content

The About menu option is in the wrong menu on macOS. #7289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cthart opened this issue Mar 18, 2024 · 2 comments
Closed

The About menu option is in the wrong menu on macOS. #7289

cthart opened this issue Mar 18, 2024 · 2 comments
Assignees
@pravesh-sharma
Labels
Bug EDB Sprint 178
Milestone
8.13

Comments

@cthart
Copy link

cthart commented Mar 18, 2024

Under macOS, the About menu option ("About pgAdmin 4") should be at the top of the application menu ("pgAdmin 4"), and not in the "Help" menu.
@cthart cthart added the Bug label Mar 18, 2024
@khushboovashi khushboovashi added Feature and removed Bug labels Mar 22, 2024
@akshay-joshi akshay-joshi moved this to 🆕 New in Current Sprint (192) Sep 27, 2024
@RohitBhati8269 RohitBhati8269 moved this from 🆕 New to 🏗 In Progress in Current Sprint (192) Sep 27, 2024
RohitBhati8269 pushed a commit to RohitBhati8269/pgadmin4 that referenced this issue Sep 30, 2024
Move About pgAdmin 4 menu option to top of application menu for macOS.p…
51d86ff 
…gadmin-org#7289
@RohitBhati8269 RohitBhati8269 mentioned this issue Sep 30, 2024
Merged
RohitBhati8269 pushed a commit to RohitBhati8269/pgadmin4 that referenced this issue Oct 3, 2024
Move About pgAdmin 4 menu option to top of application menu for macOS.p…
884644e 
…gadmin-org#7289
RohitBhati8269 pushed a commit to RohitBhati8269/pgadmin4 that referenced this issue Oct 3, 2024
1. Move 'About pgAdmin 4' menu option to top of application menu for …
3131faf 
…macOS.pgadmin-org#7289

2. Fixed desktop application minimized issue when double click on title bar.pgadmin-org#7988
adityatoshniwal pushed a commit that referenced this issue Oct 3, 2024
@RohitBhati8269
- Move 'About pgAdmin 4' to app menu on macOS. #7289
33c88ce 
- Add appropriate minimum width and height setting for desktop apps to avoid app accidentally going below visibility levels. #7988
@adityatoshniwal adityatoshniwal moved this from In Review to In Testing in Current Sprint (192) Oct 3, 2024
@adityatoshniwal adityatoshniwal added this to the 8.13 milestone Oct 3, 2024
@akshay-joshi akshay-joshi added Bug and removed Feature labels Oct 4, 2024
@pravesh-sharma pravesh-sharma self-assigned this Oct 7, 2024
@pravesh-sharma
Copy link
Contributor

Feature implemented and is working fine. Tested on snapshot build.

Env:
OS - macOS 14.7 (Sonoma)
Mode - Desktop

@pravesh-sharma pravesh-sharma moved this from In Testing to ✅ Done in Current Sprint (192) Oct 7, 2024
@cthart
Copy link
Author

cthart commented Oct 7, 2024

This looks great on my macOS 15.0.1 machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pravesh-sharma pravesh-sharma

Labels
Bug EDB Sprint 178
Projects
None yet
Milestone
8.13
Development

No branches or pull requests
6 participants
@cthart @akshay-joshi @khushboovashi @adityatoshniwal @pravesh-sharma @RohitBhati8269