Closed
Conversation
Collaborator
|
Is this covered by existing unit tests? Perhaps these: https://github.com/petertodd/python-bitcoinlib/blob/master/bitcoin/tests/test_wallet.py |
Author
|
@kanzure The whole test suite is broken when running using OpenSSL 3 . Here's the bug report that led to this finding: |
Owner
|
Fixed with #277, which also had a test suite. Thanks! |
Owner
|
@kanzure do you want to make a new python-bitcoinlib release that fixes this, or should I? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I'm the maintainer of
python-bitcoinlibfor the Debian Operative System.OpenSSL3 has disabled various legacy hash functions by moving them to a legacy provider that isn't enabled by default, includingRIRPEMD160.Since May Debian ships
OpenSSL 3which has dropped the support forRIPEMD160breaking python-bitcoinlib raising the following error:E ValueError: unsupported hash type ripemd160This PR adds the pure Python implementation based on the implementation from the embit project.