Skip to content

Byte.parseHex(String str) could throw IllegalArgumentException #37

Closed
Closed
Byte.parseHex(String str) could throw IllegalArgumentException#37
Assignees
patrickfav
Labels
bugenhancement
Milestone
v1.2.0

Description

@petrukhnov
petrukhnov
opened on May 10, 2019

Byte.parseHex(String str) could throw IllegalArgumentException on malformed string. It is not mentioned in docs or javadoc.

java.lang.IllegalArgumentException: invalid hex string, must be mod 2 == 0
	at at.favre.lib.bytes.BinaryToTextEncoding$Hex.decode(BinaryToTextEncoding.java:108)
	at at.favre.lib.bytes.Bytes.parse(Bytes.java:652)
	at at.favre.lib.bytes.Bytes.parseHex(Bytes.java:603)

Activity

  1. patrickfav commented on May 10, 2019

    @patrickfav
    patrickfav
    on May 10, 2019
    Owner

    Thanks for reporting, I will add a hint in the javadoc

  2. patrickfav commented on May 23, 2019

    @patrickfav
    patrickfav
    on May 23, 2019
    Owner

    On a different thought, since the decoder is very forgiving, I added the feature that it also accepts odd number length strings with auto padding of zero, so currently (ie. next release 1.2.0) it supports:

    • Upper- and lowercase a-f (also mixed case)
    • Prefix with 0x which will be ignored
    • Even and odd number of string length with auto zero padding (ie. 'E3F' is same as '0E3F')
  3. patrickfav
    added this to the v1.2.0 milestone on May 23, 2019
  4. patrickfav
    self-assigned this
    on May 23, 2019
  5. patrickfav
    added
    bug
    enhancement
    on May 23, 2019
  6. patrickfav
    added a commit that references this issue on May 23, 2019

    Let hex decoder accept even and odd number of string length

    e126104

  7. patrickfav commented on May 23, 2019

    @patrickfav
    patrickfav
    on May 23, 2019
    Owner

    Will be released with 1.2.0

  8. patrickfav
    closed this as completedon May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugenhancement

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions