TODO updated#2
Merged
brenosilva merged 1 commit intoOct 26, 2012
Merged
Conversation
Author
|
TODO updated |
This was referenced Oct 17, 2013
ghost
mentioned this pull request
This was referenced Oct 28, 2014
Closed
Closed
Closed
abhijoglekar
pushed a commit
to avinetworks/ModSecurity
that referenced
this pull request
Aug 22, 2017
…ecurity#2) * Support --enable-debug-logs=no option of configure script * Undo unintended white space changes * Undo more unintended white space changes * Address review comments - thanks Mirko * Address more review comments - thanks Mirko
zimmerle
pushed a commit
that referenced
this pull request
Aug 24, 2017
* Support --enable-debug-logs=no option of configure script * Undo unintended white space changes * Undo more unintended white space changes * Address review comments - thanks Mirko * Address more review comments - thanks Mirko
Closed
EunjinLee08
pushed a commit
to EunjinLee08/ModSecurity
that referenced
this pull request
Nov 10, 2025
…fdf6_bump-cosign-400md Create 박성하_e1ffdf6_Bump-cosign-4.0.0.md
g4mm4-VCF
added a commit
to g4mm4-VCF/ModSecurity
that referenced
this pull request
May 10, 2026
1. Add missing bound check before reading value_len (Copilot owasp-modsecurity#1 — real bug). After consuming the name field, blob_offset can advance to exactly blob_size; the subsequent 16-bit read of value_len from blob[blob_offset] / blob[blob_offset+1] would then OOB-read on a truncated blob. Fixed with the standard 2-byte check. 2. Drop tests/regression/persist_dbm/ (Copilot owasp-modsecurity#2-owasp-modsecurity#5). The directory was not wired into the Autotools build (no AC_CONFIG_FILES nor parent SUBDIRS entry), and the existing tests/regression/ is a Perl-based HTTP integration harness that doesn't fit a unit test of a static function. Wiring it into tests/Makefile.am where msc_test lives would require non-trivial restructuring; keeping the standalone harness outside the upstream tree (in the security advisory's PoC archive) is the cleaner path for now. Refs: PR owasp-modsecurity#3560 review comments by github-actions[bot] / Copilot.
3 tasks
g4mm4-VCF
added a commit
to g4mm4-VCF/ModSecurity
that referenced
this pull request
May 10, 2026
1. Add missing bound check before reading value_len (Copilot owasp-modsecurity#1 — real bug). After consuming the name field, blob_offset can advance to exactly blob_size; the subsequent 16-bit read of value_len from blob[blob_offset] / blob[blob_offset+1] would then OOB-read on a truncated blob. Fixed with the standard 2-byte check. 2. Drop tests/regression/persist_dbm/ (Copilot owasp-modsecurity#2-owasp-modsecurity#5). The directory was not wired into the Autotools build (no AC_CONFIG_FILES nor parent SUBDIRS entry), and the existing tests/regression/ is a Perl-based HTTP integration harness that doesn't fit a unit test of a static function. Wiring it into tests/Makefile.am where msc_test lives would require non-trivial restructuring; keeping the standalone harness outside the upstream tree (in the security advisory's PoC archive) is the cleaner path for now. Refs: PR owasp-modsecurity#3560 review comments by github-actions[bot] / Copilot.
g4mm4-VCF
added a commit
to g4mm4-VCF/ModSecurity
that referenced
this pull request
May 14, 2026
1. Add missing bound check before reading value_len (Copilot owasp-modsecurity#1 — real bug). After consuming the name field, blob_offset can advance to exactly blob_size; the subsequent 16-bit read of value_len from blob[blob_offset] / blob[blob_offset+1] would then OOB-read on a truncated blob. Fixed with the standard 2-byte check. 2. Drop tests/regression/persist_dbm/ (Copilot owasp-modsecurity#2-owasp-modsecurity#5). The directory was not wired into the Autotools build (no AC_CONFIG_FILES nor parent SUBDIRS entry), and the existing tests/regression/ is a Perl-based HTTP integration harness that doesn't fit a unit test of a static function. Wiring it into tests/Makefile.am where msc_test lives would require non-trivial restructuring; keeping the standalone harness outside the upstream tree (in the security advisory's PoC archive) is the cleaner path for now. Refs: PR owasp-modsecurity#3560 review comments by github-actions[bot] / Copilot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For tests