Add Jackson 3 plugin and migrate publishing to maven-publish#185
Open
Sboti03 wants to merge 10 commits intoorigin-energy:masterfrom
Open
Add Jackson 3 plugin and migrate publishing to maven-publish#185Sboti03 wants to merge 10 commits intoorigin-energy:masterfrom
Sboti03 wants to merge 10 commits intoorigin-energy:masterfrom
Conversation
jackmatt2
reviewed
Apr 18, 2026
| mavenCentral() | ||
| } | ||
|
|
||
| if (subproject.name == 'java-snapshot-testing-plugin-jackson3') { |
Member
There was a problem hiding this comment.
Why is this long if else needed as it wasn't required previously? Will the code work without it?
Author
There was a problem hiding this comment.
The Jackson 3 module needs Java 17 because Jackson 3 artifacts require Java 17.
The long root if/else is not needed the default can stay Java 11 and Jackson 3 can override locally.
| afterEvaluate { | ||
| if (project.hasProperty("sign")) { | ||
| signing { | ||
| sign publishing.publications |
Member
There was a problem hiding this comment.
Why did this get separated from the project.hasProperty("sign") step?
Author
There was a problem hiding this comment.
Because publishing metadata is required for every Maven publication.
Signing is optional and should only control signature generation.
Author
|
@jackmatt2 I've made the fixes you requested and fixed the pipelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Build and publishing
Jackson 3 support
Validation
Ran:
./gradlew publishToMavenLocal
./gradlew :java-snapshot-testing-plugin-jackson3:test publishToMavenLocal
Notes
fixes #183