[#70243] Fix FrozenError when diffing commits
#21504
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a FrozenError that occurs when diffing commits. The error happens when attempting to call force_encoding on a frozen string literal without first creating a mutable copy.
Key Changes
- Added
.dupbefore.force_encoding("UTF-8")in theline_to_htmlmethod to handle frozen string literals correctly
Co-authored-by: myabc <755+myabc@users.noreply.github.com>
myabc
changed the title
FrozenError when diffing commits
| DIFF | ||
| end | ||
|
|
||
| it "handles frozen strings without raising FrozenError" do |
There was a problem hiding this comment.
I asked Copilot to generate a spec, but I'm not convinced of its usefulness. I don't think we need to check every method doesn't error with an assertion.
There was a problem hiding this comment.
They are totally useless: the tests still pass if we revert back to the old code without calling dup.
Either we find better tests, or we remove them.
What makes the input string with repositories so special that it creates a FrozenError?
| DIFF | ||
| end | ||
|
|
||
| it "handles frozen strings without raising FrozenError" do |
There was a problem hiding this comment.
They are totally useless: the tests still pass if we revert back to the old code without calling dup.
Either we find better tests, or we remove them.
What makes the input string with repositories so special that it creates a FrozenError?
myabc
changed the title
FrozenError when diffing commitsFrozenError when diffing commits
Ticket
https://community.openproject.org/projects/openproject/work_packages/70243
What are you trying to accomplish?
Fixes a Ruby
FrozenError.Possibly a result of 50be32c / #19980
Merge checklist