Skip to content

feat: support acknowledged source namespace deletion - #47

Open
tmshort wants to merge 1 commit into
migration-install-namespace-corefrom
migration-install-namespace-delete
Open

tmshort wants to merge 1 commit into
migration-install-namespace-corefrom
migration-install-namespace-delete

Conversation

@tmshort

@tmshort tmshort commented Sep 24, 2026

Copy link
Copy Markdown
Member

Summary

Adds an explicit, opt-in path to delete the source namespace after a successful cross-namespace migration.

  • Adds --acknowledge-namespace-delete and rejects unsafe flag combinations.
  • Records the acknowledgment on the ClusterExtension.
  • Deletes the source namespace only after target installation and OLMv0 cleanup.
  • Extends dry-run and unit-test coverage for the destructive action.

Depends on

  • migration-install-namespace-core

Validation

  • go test ./migration/... -count=1

@openshift-ci

openshift-ci Bot commented Sep 24, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign grokspawn for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 24ac500c-71c4-4730-bbe1-9cd710610885

📥 Commits

Reviewing files that changed from the base of the PR and between ef0fb14 and 607798f.

📒 Files selected for processing (6)
  • migration/examples/cmd/migrate-operators-v0-to-v1/convert.go
  • migration/examples/cmd/migrate-operators-v0-to-v1/convert_test.go
  • migration/pkg/migration/migration.go
  • migration/pkg/migration/namespace.go
  • migration/pkg/migration/types.go
  • migration/pkg/migration/unit_test.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tmshort
tmshort force-pushed the migration-install-namespace-delete branch from f9477cc to e49f1c4 Compare September 24, 2026 19:47
@tmshort
tmshort force-pushed the migration-install-namespace-delete branch 2 times, most recently from 9a082de to e49f1c4 Compare September 24, 2026 20:07
@tmshort
tmshort force-pushed the migration-install-namespace-delete branch from e49f1c4 to 975d850 Compare September 24, 2026 20:15
@tmshort
tmshort added this pull request to stack #50 September 24, 2026 20:33
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
tmshort force-pushed the migration-install-namespace-delete branch from 975d850 to 607798f Compare September 25, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant