Skip to content

Comments

change logo_format type from string to image blob#50

Merged
benoit74 merged 1 commit intomainfrom
offliner-definitions-blob-types
Dec 16, 2025
Merged

change logo_format type from string to image blob#50
benoit74 merged 1 commit intomainfrom
offliner-definitions-blob-types

Conversation

@elfkuzco
Copy link
Contributor

@elfkuzco elfkuzco commented Dec 15, 2025

Rationale

See openzim/zimfarm#1572

Changes

  • change logo_format to image blob

@elfkuzco elfkuzco self-assigned this Dec 15, 2025
@elfkuzco elfkuzco requested a review from benoit74 December 15, 2025 12:26
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.28%. Comparing base (a944214) to head (7d37539).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files           4        4           
  Lines         376      376           
  Branches       37       37           
=======================================
  Hits          347      347           
  Misses         25       25           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoit74 benoit74 merged commit 3ddcae7 into main Dec 16, 2025
8 checks passed
@benoit74 benoit74 deleted the offliner-definitions-blob-types branch December 16, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants