Conversation
Pull request dashboard statusWaiting on maintainers · refreshed 2026-09-21 15:26 UTC Merge when ready. Status above doesn't look right?
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8838 +/- ##
============================================
+ Coverage 91.34% 91.37% +0.03%
- Complexity 10652 10657 +5
============================================
Files 1010 1010
Lines 28696 28698 +2
Branches 3682 3682
============================================
+ Hits 26212 26224 +12
+ Misses 1683 1671 -12
- Partials 801 803 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
psx95
approved these changes
Sep 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8836
Description
SdkLoggerProvider.loggerBuilder()returnsLoggerProvider.noop().loggerBuilder(name)when noLogRecordProcessoris configured, butget()skipped that check and always built a realSdkLogger.get("x").isEnabled(Severity.INFO)returnedtruewhileloggerBuilder("x").build().isEnabled(...)returnedfalse; the Logs SDK spec requiresEnabledto returnfalsewhen no processors are registered. TheSdkLoggeralso allocated a record and countedotel.sdk.log.createdon every emit beforeNoopLogRecordProcessordropped it.SdkLoggerProvider.get()calls are affected;OpenTelemetrySdk.getLogsBridge().get()already routes throughloggerBuilder().get()now returnsLoggerProvider.noop().get(name)under the sameisNoopLogRecordProcessorcondition, matchingloggerBuilder()andSdkMeterProvider. The check was lost in Optimize log hot path #4913, which replacedloggerBuilder(name).build()with a direct registry lookup.Related: #8740 / #8815 (same shortcut for
SdkTracerProvider), specspecification/logs/sdk.md"Enabled".Testing done
SdkLoggerProviderTest#get_NoProcessor_UsesNoop; it failed before the fix (SdkLoggervsDefaultLogger) and passes after../gradlew :sdk:logs:check— 90 tests + 22testIncubatingpassed../gradlew :sdk:all:test— 23 tests passed.docs/apidiffsunchanged.